standardize variable naming and simplify HITL condition in task edit view

Author: eiresendez

ProcessMaker/Http/Controllers/TaskController.php

@@ -140,7 +140,7 @@ public function edit(ProcessRequestToken $task, string $preview = '')
         $element = $task->getDefinition(true);
         $screenFields = $screenVersion ? $screenVersion->screenFilteredFields() : [];
         $taskDraftsEnabled = TaskDraft::draftsEnabled();
-        $is_smart_extract_task = $task->element_name === 'Manual Document Review';
+        $isSmartExtractTask = $task->element_name === 'Manual Document Review';
         // Remove screen parent to reduce the size of the response
         $screen = $task->screen;
         $screen['parent'] = null;
@@ -204,8 +204,7 @@ public function edit(ProcessRequestToken $task, string $preview = '')
                 'screenFields' => $screenFields,
                 'taskDraftsEnabled' => $taskDraftsEnabled,
                 'userConfiguration' => $userConfiguration,
-                'hitlEnabled' => config('smart-extract.hitl_enabled', false),
-                'is_smart_extract_task' => $is_smart_extract_task,
+                'hitlEnabled' => config('smart-extract.hitl_enabled', false) && $isSmartExtractTask,
             ]);
         }
     }

resources/views/tasks/edit.blade.php

@@ -87,7 +87,7 @@ class="nav-link">
             <div id="tabContent" class="tab-content tw-flex tw-flex-col tw-grow tw-overflow-y-scroll">
               <div id="tab-form" role="tabpanel" aria-labelledby="tab-form" class="tab-pane active show">
                 @can('update', $task)
-                  @unless($hitlEnabled && $is_smart_extract_task)
+                  @unless($hitlEnabled)
                     <task
                       ref="task"
                       class="card border-0"
@@ -108,7 +108,7 @@ class="card border-0"
                       @redirect="redirectToTask"
                       @form-data-changed="handleFormDataChange" />
                   @else
-                  @include('tasks.partials.hitl-iframe')
+                    @include('tasks.partials.hitl-iframe')
                   @endunless
                 @endcan
                 <div v-if="taskHasComments">