refactor: add type hints to node creation tests and ignore type comparison overlaps

Author: ProKil

src/aact/nodes/base.py

@@ -182,7 +182,7 @@ def __init__(
                         f"Input channel type {input_channel_type} is not a subclass of DataModel"
                     )
                 elif (
-                    input_channel_type.model_fields["data_type"].annotation
+                    input_channel_type.model_fields["data_type"].annotation  # type: ignore[comparison-overlap]
                     == Literal[""]
                 ):
                     raise TypeError(
@@ -194,7 +194,7 @@ def __init__(
                         f"Output channel type {output_channel_type} is not a subclass of DataModel"
                     )
                 elif (
-                    output_channel_type.model_fields["data_type"].annotation
+                    output_channel_type.model_fields["data_type"].annotation  # type: ignore[comparison-overlap]
                     == Literal[""]
                 ):
                     raise TypeError(

tests/nodes/test_node_creation.py

@@ -5,7 +5,7 @@
 from aact.nodes import NodeFactory
 
 
-def test_node_with_non_datamodel_types():
+def test_node_with_non_datamodel_types() -> None:
     """Test that creating a node with non-DataModel types raises a TypeError."""
 
     class AWrong:
@@ -24,9 +24,9 @@ def __init__(self) -> None:
                 output_channel_types=[("output", BWrong)],
             )
 
-        async def event_handler(
+        async def event_handler(  # type: ignore[override]
             self, input_channel: str, input_message: AWrong
-        ) -> None:  # type: ignore[override]
+        ) -> None:
             # Handle the event
             pass
 
@@ -40,7 +40,7 @@ async def event_handler(
     )
 
 
-def test_node_with_unregistered_datamodel_types():
+def test_node_with_unregistered_datamodel_types() -> None:
     """Test that creating a node with unregistered DataModel types raises a TypeError."""
 
     class ACorrect(DataModel):
@@ -59,9 +59,9 @@ def __init__(self) -> None:
                 output_channel_types=[("output", BCorrect)],
             )
 
-        async def event_handler(
+        async def event_handler(  # type: ignore[override]
             self, input_channel: str, input_message: ACorrect
-        ) -> None:  # type: ignore[override]
+        ) -> None:
             # Handle the event
             pass
 
@@ -75,7 +75,7 @@ async def event_handler(
     )
 
 
-def test_node_with_registered_datamodel_types():
+def test_node_with_registered_datamodel_types() -> None:
     """Test that creating a node with properly registered DataModel types succeeds."""
 
     @DataModelFactory.register("ACorrectNew")
@@ -96,9 +96,9 @@ def __init__(self) -> None:
                 output_channel_types=[("output", BCorrectNew)],
             )
 
-        async def event_handler(
+        async def event_handler(  # type: ignore[override]
             self, input_channel: str, input_message: ACorrectNew
-        ) -> None:  # type: ignore[override]
+        ) -> None:
             # Handle the event
             pass