Remove feature selection cell from TabPFN_Demo_Local notebook#978
Open
adrian-prior wants to merge 2 commits into
Open
Remove feature selection cell from TabPFN_Demo_Local notebook#978adrian-prior wants to merge 2 commits into
adrian-prior wants to merge 2 commits into
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
alanprior
approved these changes
May 22, 2026
Contributor
alanprior
left a comment
alanprior
left a comment
There was a problem hiding this comment.
LGTM, but best if @eliott-kalfon also gives a look as I think he was looking into these things.
Contributor
|
Hi @alanprior, I was not involved in this but happy to test this on Tuesday morning when I get back. Please do not let my review hold the merge |
Contributor
eliott-kalfon
left a comment
eliott-kalfon
left a comment
There was a problem hiding this comment.
@adrian-prior did running the notebook work for you? I get plenty of errors. I will debug on Tuesday. If you want to merge as is, I would still like to fix these next week
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/notebooks/TabPFN_Demo_Local.ipynb. -> This is because feature selection is pretty expensive and generally not very helpful for TabPFN (at least using the feature selection extensions).Test plan