Caught another case where we need to unescape a path (cwd) sent via the launch request from vscode.

Also replaced the PowerShell code to execute Set-Location, with a call to SessionStateProxy.Path.SetLocation.  I think this should be safer.

Author: rkeithhill

src/PowerShellEditorServices.Protocol/Server/DebugAdapter.cs

@@ -85,6 +85,7 @@ protected async Task HandleLaunchRequest(
             // In case that is null, use the the folder of the script to be executed.  If the resulting 
             // working dir path is a file path then extract the directory and use that.
             string workingDir = launchParams.Cwd ?? launchParams.Program;
+            workingDir = PowerShellContext.UnescapePath(workingDir);
             try
             {
                 if ((File.GetAttributes(workingDir) & FileAttributes.Directory) != FileAttributes.Directory)
@@ -94,16 +95,11 @@ protected async Task HandleLaunchRequest(
             }
             catch (Exception ex)
             {
-                Logger.Write(LogLevel.Error, "cwd path is bad: " + ex.Message);
+                Logger.Write(LogLevel.Error, "cwd path is invalid: " + ex.Message);
                 workingDir = Environment.CurrentDirectory;
             }
 
-            var setWorkingDirCommand = new PSCommand();
-            setWorkingDirCommand.AddCommand(@"Microsoft.PowerShell.Management\Set-Location")
-                .AddParameter("LiteralPath", workingDir);
-
-            await editorSession.PowerShellContext.ExecuteCommand(setWorkingDirCommand);
-
+            editorSession.PowerShellContext.SetWorkingDirectory(workingDir);
             Logger.Write(LogLevel.Verbose, "Working dir set to: " + workingDir);
 
             // Prepare arguments to the script - if specified

src/PowerShellEditorServices/Session/PowerShellContext.cs

@@ -577,13 +577,23 @@ internal void ReleaseRunspaceHandle(RunspaceHandle runspaceHandle)
             }
         }
 
+        /// <summary>
+        /// Sets the current working directory of the powershell context.  The path should be
+        /// unescaped before calling this method.
+        /// </summary>
+        /// <param name="path"></param>
+        public void SetWorkingDirectory(string path)
+        {
+            this.currentRunspace.SessionStateProxy.Path.SetLocation(path);
+        }
+
         /// <summary>
         /// Returns the passed in path with the [ and ] characters escaped. Escaping spaces is optional.
         /// </summary>
         /// <param name="path">The path to process.</param>
         /// <param name="escapeSpaces">Specify True to escape spaces in the path, otherwise False.</param>
         /// <returns>The path with [ and ] escaped.</returns>
-        internal static string EscapePath(string path, bool escapeSpaces)
+        public static string EscapePath(string path, bool escapeSpaces)
         {
             string escapedPath = Regex.Replace(path, @"(?<!`)\[", "`[");
             escapedPath = Regex.Replace(escapedPath, @"(?<!`)\]", "`]");
@@ -602,7 +612,7 @@ internal static string EscapePath(string path, bool escapeSpaces)
         /// </summary>
         /// <param name="path">The path to unescape.</param>
         /// <returns>The path with the ` character before [, ] and spaces removed.</returns>
-        internal static string UnescapePath(string path)
+        public static string UnescapePath(string path)
         {
             if (!path.Contains("`"))
             {