Rewrote Variable Handler, all tests passing except a stringconstant splat reference

Author: JustinGrote

src/PowerShellEditorServices/Services/TextDocument/RenameService.cs

@@ -0,0 +1 @@
+FunctionThatIsNotDefinedInThisScope -TestParameter 'test'

src/PowerShellEditorServices/Utility/AstExtensions.cs

@@ -18,7 +18,7 @@ public class RefactorVariableTestCases
         new ("VariableInForloopDuplicateAssignment.ps1",       Line:  9, Column: 14),
         new ("VariableInLoop.ps1",                             Line:  1, Column:  1),
         new ("VariableInParam.ps1",                            Line: 24, Column: 16),
-        new ("VariableInPipeline.ps1",                         Line:  2, Column: 23),
+        new ("VariableInPipeline.ps1",                         Line:  3, Column: 23),
         new ("VariableInScriptblockScoped.ps1",                Line:  2, Column: 16),
         new ("VariableNestedFunctionScriptblock.ps1",          Line:  4, Column: 20),
         new ("VariableNestedScopeFunction.ps1",                Line:  1, Column:  1),
@@ -31,6 +31,7 @@ public class RefactorVariableTestCases
         new ("VariableusedInWhileLoop.ps1",                    Line:  2, Column:  5),
         new ("VariableWithinCommandAstScriptBlock.ps1",        Line:  3, Column: 75),
         new ("VariableWithinForeachObject.ps1",                Line:  2, Column:  1),
-        new ("VariableWithinHastableExpression.ps1",          Line:  3, Column: 46),
+        new ("VariableWithinHastableExpression.ps1",           Line:  3, Column: 46),
+        new ("ParameterUndefinedFunction.ps1",                 Line:  1, Column: 39, ShouldFail: true),
     ];
 }

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/ParameterUndefinedFunction.ps1

@@ -1,3 +1,4 @@
+$oldVarName = 5
 1..10 |
 Where-Object { $_ -le $oldVarName } |
 Write-Output

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/RefactorVariableTestCases.cs

@@ -1,3 +1,4 @@
+$Renamed = 5
 1..10 |
 Where-Object { $_ -le $Renamed } |
 Write-Output

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableInPipeline.ps1

@@ -98,9 +98,9 @@ public async Task FindsVariable(RenameTestTarget s)
         {
             result = await testHandler.Handle(testParams, CancellationToken.None);
         }
-        catch (HandlerErrorException)
+        catch (HandlerErrorException err)
         {
-            Assert.True(s.ShouldFail);
+            Assert.True(s.ShouldFail, err.Message);
             return;
         }
         if (s.ShouldFail)

test/PowerShellEditorServices.Test.Shared/Refactoring/Variables/VariableInPipelineRenamed.ps1

@@ -98,9 +98,9 @@ public async void RenamedVariable(RenameTestTarget s)
         {
             response = await testHandler.Handle(request, CancellationToken.None);
         }
-        catch (HandlerErrorException)
+        catch (HandlerErrorException err)
         {
-            Assert.True(s.ShouldFail);
+            Assert.True(s.ShouldFail, $"Shouldfail is {s.ShouldFail} and error is {err.Message}");
             return;
         }
         if (s.ShouldFail)