Commit 648cd3e
committed
Fix all
A number of items needed to be fixed:
* `Path.Combine` instead of `Path.Join` because of .NET changes
* `ConfigureAwait(false)` because of our rule to always include that
* Pass actual script path to `BreakpointDetails.Create` so the debug
service has a valid value for its hashtable key
* Call `Close()` instead of `Dispose()` (which changed) on
`PowerShellContextService`
* Make assertion in `AssertDebuggerStopped` case-insensitive
* Increase cancellation token source timeouts to 10 seconds
* Avoid waiting for PowerShell context state change that never happens
and isn't required
* Delete unused fields or local variables
* Avoid issue with breakpoint ordering (see comment)
* Consistently abort the debugger and wait for the `executeTask`
* Make `Get-Process` test cross-platform (and execute the right line)DebugServiceTests
1 parent 301ee69 commit 648cd3e
File tree
2 files changed
+181
-172
lines changed- test
- PowerShellEditorServices.Test/Debugging
2 files changed
+181
-172
lines changedLines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
0 commit comments