Fixes to make CustomRulePath feature work

Author: raghushantha

Engine/ScriptAnalyzer.cs

@@ -711,9 +711,23 @@ private List<ExternalRule> GetExternalRule(string[] moduleNames)
                 using (System.Management.Automation.PowerShell posh =
                        System.Management.Automation.PowerShell.Create(state))
                 {
-                    posh.AddCommand("Get-Module").AddParameter("Name", moduleName).AddParameter("ListAvailable");
-                    shortModuleName = posh.Invoke<PSModuleInfo>().First().Name;   
-                                                            
+                    posh.AddCommand("Get-Module");
+                    Collection<PSModuleInfo> loadedModules = posh.Invoke<PSModuleInfo>();                    
+                    foreach (PSModuleInfo module in loadedModules)
+                    {
+                        string pathToCompare = moduleName;
+                        if (!File.GetAttributes(moduleName).HasFlag(FileAttributes.Directory))
+                        {
+                            pathToCompare = Path.GetDirectoryName(moduleName);
+                        }
+
+                        if (pathToCompare == Path.GetDirectoryName(module.Path))
+                        {
+                           shortModuleName = module.Name;
+                           break;
+                        }
+                    }
+                                        
                     // Invokes Get-Command and Get-Help for each functions in the module.
                     posh.Commands.Clear();
                     posh.AddCommand("Get-Command").AddParameter("Module", shortModuleName);
@@ -974,17 +988,33 @@ public Dictionary<string, List<string>> CheckRuleExtension(string[] path, PathIn
                         resolvedPath = basePath
                             .GetResolvedPSPathFromPSPath(childPath).First().ToString();
                     }
+                    
+                    // Import the module
+                    InitialSessionState state = InitialSessionState.CreateDefault2();
+                    state.ImportPSModule(new string[] { resolvedPath });
 
                     using (System.Management.Automation.PowerShell posh =
-                           System.Management.Automation.PowerShell.Create())
-                    {                        
-                        posh.AddCommand("Get-Module").AddParameter("Name", resolvedPath).AddParameter("ListAvailable");
-                        PSModuleInfo moduleInfo = posh.Invoke<PSModuleInfo>().First();     
-
-                        // Adds original path, otherwise path.Except<string>(validModPaths) will fail.
-                        // It's possible that user can provide something like this:
-                        // "..\..\..\ScriptAnalyzer.UnitTest\modules\CommunityAnalyzerRules\CommunityAnalyzerRules.psd1"
-                        if (moduleInfo.ExportedFunctions.Count > 0) validModPaths.Add(resolvedPath);
+                           System.Management.Automation.PowerShell.Create(state))
+                    {
+                        posh.AddCommand("Get-Module");
+                        Collection<PSModuleInfo> loadedModules = posh.Invoke<PSModuleInfo>();
+                        foreach (PSModuleInfo module in loadedModules)
+                        {
+                            string pathToCompare = resolvedPath;
+                            if (!File.GetAttributes(resolvedPath).HasFlag(FileAttributes.Directory))
+                            {
+                                pathToCompare = Path.GetDirectoryName(resolvedPath);
+                            }
+
+                            if (pathToCompare == Path.GetDirectoryName(module.Path))
+                            {
+                                if (module.ExportedFunctions.Count > 0)
+                                {
+                                    validModPaths.Add(resolvedPath);
+                                }
+                                break;
+                            }
+                        }
                     }
                 }
                 catch