Merge pull request #205 from PowerShell/FixUseDeclaredVarsMoreThanAssignment

Fix use declared vars more than assignment

Author: Quoc Truong

Rules/UseDeclaredVarsMoreThanAssignments.cs

@@ -49,12 +49,14 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             {
                 foreach (AssignmentStatementAst assignmentAst in assignmentAsts)
                 {
-                    assingmentVarAsts = assignmentAst.Left.FindAll(testAst => testAst is VariableExpressionAst, true); ;
+                    // Only checks for the case where lhs is a variable. Ignore things like $foo.property
+                    VariableExpressionAst assignmentVarAst = assignmentAst.Left as VariableExpressionAst;
 
-                    foreach (VariableExpressionAst assignmentVarAst in assingmentVarAsts)
+                    if (assignmentVarAst != null)
                     {
-                         //Ignore if variable is global or environment variable
-                        if (!Helper.Instance.IsVariableGlobalOrEnvironment(assignmentVarAst, ast))
+                        //Ignore if variable is global or environment variable
+                        if (!Helper.Instance.IsVariableGlobalOrEnvironment(assignmentVarAst, ast)
+                            && !assignmentVarAst.VariablePath.IsScript)
                         {
                             if (!assignments.ContainsKey(assignmentVarAst.VariablePath.UserPath))
                             {

Tests/Rules/UseDeclaredVarsMoreThanAssignmentsNoViolations.ps1

@@ -1,2 +1,4 @@
 $declaredVars = "Declared Vars"
-Write-Ouput $declaredVars
+Write-Ouput $declaredVars
+$script:thisshouldnotraiseerrors = "this should not raise errors"
+$foo.property = "This also should not raise errors"