Handle hashtable, array, param block in indentation rule

Author: Kapil Borle

Rules/UseConsistentIndentation.cs

@@ -71,10 +71,14 @@ public override IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string file
 
                 switch (token.Kind)
                 {
+                    case TokenKind.AtCurly:
+                    case TokenKind.AtParen:
+                    case TokenKind.LParen:
                     case TokenKind.LCurly:
                         AddViolation(token, indentationLevel++, diagnosticRecords, ref onNewLine);
                         break;
 
+                    case TokenKind.RParen:
                     case TokenKind.RCurly:
                         indentationLevel = ClipNegative(indentationLevel - 1);
                         AddViolation(token, indentationLevel, diagnosticRecords, ref onNewLine);

Tests/Rules/UseConsistentIndentation.tests.ps1

@@ -28,7 +28,7 @@ Describe "UseConsistentIndentation" {
         }
     }
 
-    Context "When nested indenation of is not consistent" {
+    Context "When nested indenation is not consistent" {
         BeforeAll {
             $def = @'
 function foo ($param1)
@@ -39,8 +39,62 @@ function foo ($param1)
             $violations = Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings
         }
 
-        It "Should detect a violation" {
+        It "Should find a violation" {
             $violations.Count | Should Be 1
         }
     }
+
+    Context "When a multi-line hashtable is provided" {
+        BeforeAll {
+            $def = @'
+$hashtable = @{
+a = 1
+b = 2
+    c = 3
+}
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings
+        }
+
+        It "Should find violations" {
+            $violations.Count | Should Be 2
+        }
+    }
+
+    Context "When a multi-line array is provided" {
+        BeforeAll {
+            $def = @'
+$array = @(
+1,
+    2,
+3)
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings
+        }
+
+        It "Should find violations" {
+            $violations.Count | Should Be 2
+        }
+    }
+
+    Context "When a param block is provided" {
+        BeforeAll {
+            $def = @'
+param(
+            [string] $param1,
+
+[string]
+    $param2,
+
+        [string]
+$param3
+)
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings
+        }
+
+        It "Should find violations" {
+            $violations.Count | Should Be 4
+        }
+    }
 }