Merge pull request #420 from PowerShell/PreferenceVarFixBranch

Fix for issue #417 - False positive - The variable 'OFS' is assigned …

Author: raghushantha

Engine/SpecialVars.cs

@@ -36,6 +36,7 @@ internal class SpecialVars
         internal const string ExecutionContext = "ExecutionContext";
         internal const string Matches = "Matches";
         internal const string PSVersionTable = "PSVersionTable";
+        internal const string OFS = "OFS";
 
         internal static readonly string[] InitializedVariables;
 
@@ -67,7 +68,8 @@ static SpecialVars()
                                                                    PSCommandPath,
                                                                    ExecutionContext,
                                                                    Matches,
-                                                                   PSVersionTable
+                                                                   PSVersionTable,
+                                                                   OFS
                                                                };
         internal static readonly Type[] AutomaticVariableTypes = new Type[]  
                                                                  {  
@@ -82,7 +84,8 @@ static SpecialVars()
                                                                    /* PSCommandPath */     typeof(string),  
                                                                    /* ExecutionContext */  typeof(EngineIntrinsics),
                                                                    /* Matches */           typeof(System.Collections.Hashtable),
-                                                                   /* PSVersionTable */    typeof(System.Collections.Hashtable)
+                                                                   /* PSVersionTable */    typeof(System.Collections.Hashtable),
+                                                                   /* OFS */               typeof(object)
                                                                  };
 
 

Tests/Rules/UseDeclaredVarsMoreThanAssignmentsNoViolations.ps1

@@ -1,4 +1,8 @@
 $declaredVars = "Declared Vars"
 Write-Ouput $declaredVars
 $script:thisshouldnotraiseerrors = "this should not raise errors"
-$foo.property = "This also should not raise errors"
+$foo.property = "This also should not raise errors"
+
+# Output field separator builtin special variable
+$OFS = ', '
+[string]('apple', 'banana', 'orange')