Use extension method to get cmdletbinding attribute

Author: Kapil Borle

Engine/Extensions.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Management.Automation;
 using System.Management.Automation.Language;
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.Extensions
@@ -42,5 +43,32 @@ public static ParameterAst[] GetParameterAsts(
 
             return null;
         }
+
+        /// <summary>
+        /// Get the CmdletBinding attribute ast
+        /// </summary>
+        /// <param name="attributeAsts"></param>
+        /// <returns>Returns CmdletBinding attribute ast if it exists, otherwise returns null</returns>
+        public static AttributeAst GetCmdletBindingAttributeAst(this ParamBlockAst paramBlockAst)
+        {
+            var attributeAsts = paramBlockAst.Attributes;
+            if (attributeAsts == null)
+            {
+                throw new ArgumentNullException("attributeAsts");
+            }
+            foreach (var attributeAst in attributeAsts)
+            {
+                if (attributeAst == null || attributeAst.NamedArguments == null)
+                {
+                    continue;
+                }
+                if (attributeAst.TypeName.GetReflectionAttributeType()
+                    == typeof(CmdletBindingAttribute))
+                {
+                    return attributeAst;
+                }
+            }
+            return null;
+        }
     }
 }

rules/UseSupportsShouldProcess.cs

@@ -277,15 +277,12 @@ private CorrectionExtent Normalize(
                  correctionExtent.File,
                  correctionExtent.Description);
         }
+
         private static bool TryGetCmdletBindingAttribute(
             ParamBlockAst paramBlockAst,
             out AttributeAst attributeAst)
         {
-            attributeAst = paramBlockAst.Attributes.FirstOrDefault(attr =>
-            {
-                return attr.TypeName.Name.Equals("cmdletbinding", StringComparison.OrdinalIgnoreCase);
-            });
-
+            attributeAst = paramBlockAst.GetCmdletBindingAttributeAst();
             return attributeAst != null;
         }