Merge pull request #311 from kapilmb/psdrivebugfix

Fixes PSDrive and wildcard matching bugs

Author: Kapil Borle

Engine/Commands/InvokeScriptAnalyzerCommand.cs

@@ -14,6 +14,7 @@
 using System;
 using System.ComponentModel;
 using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
@@ -159,9 +160,12 @@ protected override void BeginProcessing()
         /// </summary>
         protected override void ProcessRecord()
         {
-            // throws Item Not Found Exception
-            path = this.SessionState.Path.GetResolvedPSPathFromPSPath(path).First().ToString();
-            ProcessPath(path);
+            // throws Item Not Found Exception                        
+            Collection<PathInfo> paths = this.SessionState.Path.GetResolvedPSPathFromPSPath(path);
+            foreach (PathInfo p in paths)
+            {
+                ProcessPath(this.SessionState.Path.GetUnresolvedProviderPathFromPSPath(p.Path));
+            }
         }
 
         #endregion

Tests/Engine/InvokeScriptAnalyzer.tests.ps1

@@ -70,6 +70,42 @@ Describe "Test Path" {
         }
     }
 
+	if (!$testingLibraryUsage)
+	{
+		#There is probably a more concise way to do this but for now we will settle for this!
+		Function GetFreeDrive ($freeDriveLen) { 
+			$ordA = 65
+			$ordZ = 90
+			$freeDrive = ""
+			$freeDriveName = ""
+			do{
+				$freeDriveName = (1..$freeDriveLen | %{[char](Get-Random -Maximum $ordZ -Minimum $ordA)}) -join ''
+				$freeDrive = $freeDriveName + ":"    
+			}while(Test-Path $freeDrive)
+			$freeDrive, $freeDriveName
+		}
+
+		Context "When given a glob" {
+    		It "Invokes on all the matching files" {
+			$numFilesResult = (Invoke-ScriptAnalyzer -Path $directory\Rule*.ps1 | Select-Object -Property ScriptName -Unique).Count
+			$numFilesExpected = (Get-ChildItem -Path $directory\Rule*.ps1).Count
+			$numFilesResult | Should be $numFilesExpected
+			}
+		}
+
+		Context "When given a FileSystem PSDrive" {
+    		It "Recognizes the path" {
+			$freeDriveNameLen = 2
+			$freeDrive, $freeDriveName = GetFreeDrive $freeDriveNameLen
+			New-PSDrive -Name $freeDriveName -PSProvider FileSystem -Root $directory
+			$numFilesExpected = (Get-ChildItem -Path $freeDrive\R*.ps1).Count
+			$numFilesResult = (Invoke-ScriptAnalyzer -Path $freeDrive\Rule*.ps1 | Select-Object -Property ScriptName -Unique).Count
+			Remove-PSDrive $freeDriveName
+			$numFilesResult | Should Be $numFilesExpected
+			}
+		}
+	}
+
     Context "When given a directory" {
         $withoutPathWithDirectory = Invoke-ScriptAnalyzer -Recurse $directory\RecursionDirectoryTest
         $withPathWithDirectory = Invoke-ScriptAnalyzer -Recurse -Path $directory\RecursionDirectoryTest