Merge pull request #649 from PowerShell/kapilmb/ExternalRuleScriptPath

Fix external rules ScriptPath property

Author: Kapil Borle

Engine/ScriptAnalyzer.cs

@@ -1993,7 +1993,7 @@ public IEnumerable<DiagnosticRecord> AnalyzeSyntaxTree(
                     }
                 }
 
-                foreach (var ruleRecord in this.GetExternalRecord(scriptAst, scriptTokens, exRules.ToArray(), fileName))
+                foreach (var ruleRecord in this.GetExternalRecord(scriptAst, scriptTokens, exRules.ToArray(), filePath))
                 {
                     var records = SuppressRule(ruleSuppressions, ruleRecord);
                     foreach (var record in records.Item2)

Tests/Engine/CustomizedRule.tests.ps1

@@ -150,6 +150,17 @@ Describe "Test importing correct customized rules" {
             $customizedRulePath.Count | Should Be 1
         }
 
+		It "will set ScriptName property to the target file name" {
+			$violations = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomizedRulePath $directory\samplerule
+			$violations[0].ScriptName | Should Be 'TestScript.ps1'
+		}
+
+		It "will set ScriptPath property to the target file path" {
+			$violations = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomizedRulePath $directory\samplerule
+			$expectedScriptPath = Join-Path $directory 'TestScript.ps1'
+			$violations[0].ScriptPath | Should Be $expectedScriptPath
+		}
+
         if (!$testingLibraryUsage)
 		{
             It "will show the custom rule in the results when given a rule folder path with trailing backslash" {