Removed using System.Linq; and added some tests

Author: iRon7

Rules/AvoidDynamicVariableNames.cs

@@ -6,7 +6,6 @@
 using System.Collections.Generic;
 using System.Globalization;
 using System.Management.Automation.Language;
-using System.Linq;
 
 #if !CORECLR
 using System.ComponentModel.Composition;

Tests/Rules/AvoidDynamicVariableNames.tests.ps1

@@ -19,6 +19,7 @@ Describe "AvoidDynamicVariableNames" {
             $violations.Extent.Text | Should -Be {New-Variable -Name $Test}.ToString()
             $violations.Message     | Should -Be ($ruleMessage -f '$Test')
         }
+
         It "Common dynamic variable iteration" {
             $scriptDefinition = {
                 'One', 'Two', 'Three' | ForEach-Object -Begin { $i = 1 } -Process {
@@ -32,6 +33,20 @@ Describe "AvoidDynamicVariableNames" {
             $violations.Extent.Text | Should -Be {New-Variable -Name "My$_" -Value ($i++)}.ToString()
             $violations.Message     | Should -Be ($ruleMessage -f 'My$_')
         }
+
+        It "Set-Variable by positional parameter" {
+            $scriptDefinition = {
+                'One', 'Two', 'Three' | ForEach-Object -Begin { $i = 1 } -Process {
+                    New-Variable "My$_" ($i++)
+                }
+                $MyTwo # returns 2
+            }.ToString()
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations.Count       | Should -Be 1
+            $violations.Severity    | Should -Be Warning
+            $violations.Extent.Text | Should -Be {New-Variable "My$_" ($i++)}.ToString()
+            $violations.Message     | Should -Be ($ruleMessage -f 'My$_')
+        }
     }
 
     Context "Compliant" {
@@ -58,6 +73,15 @@ Describe "AvoidDynamicVariableNames" {
             $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
             $violations | Should -BeNullOrEmpty
         }
+
+        It "Verbatim (single quoted) name with dollar sign" {
+            $scriptDefinition = {
+                New-Variable -Name '$Sign'
+                Set-Variable -Name '$Sign' -Value 'Dollar'
+            }.ToString()
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDefinition -IncludeRule @($ruleName)
+            $violations | Should -BeNullOrEmpty
+        }
     }
 
     Context "Suppressed" {