Merge pull request #630 from PowerShell/kapilmb/FixUsePSCredentialType

Fix PSUsePSCredentialType rule when attributes on same line

Author: Kapil Borle

Rules/UsePSCredentialType.cs

@@ -115,7 +115,7 @@ private bool WrongCredentialUsage(ParameterAst parameter)
                 var credentialAttribute = parameter.Attributes.FirstOrDefault(paramAttribute => paramAttribute.TypeName.GetReflectionType() == typeof(CredentialAttribute));
 
                 // check that both exists and pscredentialtype comes before credential attribute
-                if (psCredentialType != null && credentialAttribute != null && psCredentialType.Extent.EndOffset < credentialAttribute.Extent.StartOffset)
+                if (psCredentialType != null && credentialAttribute != null && psCredentialType.Extent.EndOffset <= credentialAttribute.Extent.StartOffset)
                 {
                     return false;
                 }

Tests/Rules/PSCredentialType.tests.ps1

@@ -14,6 +14,21 @@ Describe "PSCredentialType" {
         It "has the correct description message" {
             $violations[0].Message | Should Be $violationMessage
         }
+
+        It "detects attributes on the same line without space" {
+            $scriptDef = @'
+function Get-Credential
+{
+    param(
+    [PSCredential][System.Management.Automation.Credential()]
+    $Credential
+    )
+}
+'@
+            $violations = Invoke-ScriptAnalyzer -ScriptDefinition $scriptDef -IncludeRule $violationName
+            $violations.Count | Should Be 0
+        }
+
     }
 
     $expectedViolationCount = 0