Loading issue with Posthog Rails

[stuyam]

I installed the new posthog-rails gem and noticed PostHog wasn't being loaded and the new rails generator didn't exist.

I believe the issue has to do with the way it is being release. As you can see in the new rails gemspec we are loading lib directory: https://github.com/PostHog/posthog-ruby/blob/main/posthog-rails/posthog-rails.gemspec#L8

spec.files = Dir.glob('lib/**/*')

Note that we are using Dir.glob which is relative to the working directory.

Then in the github action release we are building from the project working directory like: https://github.com/PostHog/posthog-ruby/blob/main/.github/workflows/release.yml#L114

run: gem build posthog-rails/posthog-rails.gemspec

I believe that the projects root lib directory is being loaded as a result. I think it either needs to change how it is being built or change how the gemspec specifies those files. We might want to change the working directory temporarily to build since there may be other consequences with loading other things relative to the posthog-rails gemspec.

PS: Great work on the posthog-rails gem, I am VERY excited about it 🎉

[johnnagro]

@rafaeelaudibert i can confirm the packaging isn't right, adding this to a new vanilla rails project Gemfile:

gem "posthog-ruby"
gem "posthog-rails"

then running bundle:

[!] There was an error parsing `Gemfile`: You cannot specify the same gem twice with different version requirements.
You specified: posthog-ruby (~> 3.3) and posthog-ruby (>= 0). Bundler cannot continue.

 #  from /Users/johnnagro/Library/CloudStorage/Dropbox/Projects/noreaster/rails-template/tmp_projects/project_9/Gemfile:86
 #  -------------------------------------------
 #
 >  gem "posthog-ruby"
 #  gem "posthog-rails"
 #  -------------------------------------------

this leads me to believe that both gems probably contain the posthog-ruby stuff

[rafaeelaudibert]

Ok, that makes sense, I'll work on a fix. Thank you for reporting!

[rafaeelaudibert]

#94 should fix this

[rafaeelaudibert]

@stuyam @johnnagro do you mind confirming the fix? I've started a bare rails new my_project locally, added posthog-ruby and posthog-rails to it and it installs successfuly now.

bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Fetching posthog-ruby 3.5.1
Installing posthog-ruby 3.5.1
Fetching posthog-rails 3.5.1
Installing posthog-rails 3.5.1
Bundle complete! 19 Gemfile dependencies, 108 gems now installed.
Bundled gems are installed into `/Users/rafael/.rvm/gems/ruby-3.1.4@lead_simple`
1 installed gem you directly depend on is looking for funding.
  Run `bundle fund` for details

[johnnagro]

@rafaeelaudibert it installs cleanly now but there might be another issue

[johnnagro]

~> rails generate posthog:install
/Users/johnnagro/.local/share/mise/installs/ruby/3.4.5/lib/ruby/gems/3.4.0/gems/posthog-rails-3.5.1/lib/posthog/rails/railtie.rb:79:in 'block in <class:Railtie>': undefined method 'insert_middleware_after' for an instance of PostHog::Rails::Railtie (NoMethodError)

        insert_middleware_after(
        ^^^^^^^^^^^^^^^^^^^^^^^

[johnnagro]

i think you fixed the packaging issue, now we have: #97 - i will have a PR for you shortly.

[rafaeelaudibert]

Thank you @johnnagro! I'll close this one and we can focus on #97 now