From 4c21fbbb7006804b1b870178d90356c6483fa663 Mon Sep 17 00:00:00 2001 From: Heitor Neiva Date: Mon, 3 Jun 2024 17:40:13 -0700 Subject: [PATCH] Fix apple api returning unsorted data Apple has changed something on their end broke the paging functionality of listing users and invites without a sorting key. I think it's sensible to default sorting users by "username" and invites by "email" to avoid this problem. (it's beyond me why apple uses "username" for users and "email" for invites) --- appstoreconnect/api.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appstoreconnect/api.py b/appstoreconnect/api.py index 36085ca..d37013e 100644 --- a/appstoreconnect/api.py +++ b/appstoreconnect/api.py @@ -355,14 +355,14 @@ def modify_user_account( """ return self._modify_resource(user, locals()) - def list_users(self, filters=None, sort=None): + def list_users(self, filters=None, sort="username"): """ :reference: https://developer.apple.com/documentation/appstoreconnectapi/list_users :return: an iterator over User resources """ return self._get_resources(User, filters, sort) - def list_invited_users(self, filters=None, sort=None): + def list_invited_users(self, filters=None, sort="email"): """ :reference: https://developer.apple.com/documentation/appstoreconnectapi/list_invited_users :return: an iterator over UserInvitation resources