You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 19, 2024. It is now read-only.
If you at any time set the paper-icon-button alt property to undefined (which is easily done when using bindings), it stops updating the aria-label attribute and it gets stuck with the value "undefined".
The problem is in the guard that checks the old value against the current value of the aria-label attribute (the oldValue == label comparison) - it doesn't handle non-string values correctly. oldValue should be converted to a string before comparing.
Expected outcome
Changing the alt property should update the aria-label attribute.
Description
If you at any time set the paper-icon-button alt property to undefined (which is easily done when using bindings), it stops updating the aria-label attribute and it gets stuck with the value "undefined".
The problem is in the guard that checks the old value against the current value of the aria-label attribute (the
oldValue == labelcomparison) - it doesn't handle non-string values correctly.oldValueshould be converted to a string before comparing.Expected outcome
Changing the alt property should update the aria-label attribute.
Actual outcome
aria-label will keep having "undefined" as value
Steps to reproduce
paper-icon-buttonelement in the page.