[Bug]: Valid checks don't suppress undefined-global

[Pollux12]

Area

Language server

What happened?

Valid checks (such as IsValid) do not correctly suppress undefined-global for the rest of that scope. The expected result is that we should be narrowing the type to be any (depends on the check) even if undefined before for the rest of that scope, since if it was actually invalid, the code scoped within the valid check would not run.

How can it be reproduced?

undefined-global diagnostic should not occur in these examples:

local function TestFunction()
	if not testVar then return end 
	if not testVar.Field then return end -- diagnostic on testVar: undefined global variable: testVar GLuaLS(undefined-global)
	print(testVar) -- diagnostic on testVar: undefined global variable: testVar GLuaLS(undefined-global)
end

local function TestFunction2()
    if not istable(testVar2) then return end -- testVar2 = any
    if not testVar2.TestField then return end -- testVar2 = table but still giving undefined-global diagnostic
    print(testVar2.TestField) -- testVar2 = table and field TestField = any but still giving undefined-global diagnostic
end

Additional info

No response

[Pollux12]

Partially fixed in 1.0.6 - error diagnostic no longer shows but type is still incorrect (shows type unknown, should be type any for generic checks).

[Pollux12]

Fixed in 1.0.7