Fix climate_action_incentive_category enum crash (#550)

* Fix climate_action_incentive_category enum crash

select() with no default returns 0 (int) when no condition matches,
which fails enum encoding. This happens for children in two-parent
households who don't match any of the four conditions.

Add default=OTHER_CHILD so unmatched persons get a valid enum value.
This unblocks household_net_income and marginal_tax_rate calculations.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add tests for climate_action_incentive_category fix

- Test category assignment for two-parent household with child (the crash case)
- Test single-parent household eldest child gets special category
- Test single person gets HEAD
- Integration test for two-parent and married-couple households

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add changelog entry for climate action category fix

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: PavelMakarchuk

changelog.d/fixed/fix-climate-action-category.md

@@ -0,0 +1 @@
+Fixed climate_action_incentive_category enum crash that broke household_net_income and marginal_tax_rate for all household types.

policyengine_canada/tests/gov/cra/tax/income/credits/climate_action/climate_action_incentive_category.yaml

@@ -0,0 +1,74 @@
+- name: Two-parent household with child — category defaults without crash
+  period: 2026
+  input:
+    people:
+      parent1:
+        age: 35
+        is_head: true
+        is_spouse: false
+        employment_income: 50_000
+      parent2:
+        age: 33
+        is_head: false
+        is_spouse: true
+      child:
+        age: 5
+        is_head: false
+        is_spouse: false
+    households:
+      household:
+        members: [parent1, parent2, child]
+        province_code: ONT
+        is_married: true
+  output:
+    climate_action_incentive_category:
+      - HEAD
+      - SPOUSE
+      - OTHER_CHILD
+
+- name: Single parent household — eldest child gets special category
+  period: 2026
+  input:
+    people:
+      parent:
+        age: 35
+        is_head: true
+        is_spouse: false
+        employment_income: 45_000
+      child1:
+        age: 10
+        is_head: false
+        is_spouse: false
+        is_dependant: true
+      child2:
+        age: 7
+        is_head: false
+        is_spouse: false
+        is_dependant: true
+    households:
+      household:
+        members: [parent, child1, child2]
+        province_code: ONT
+        is_married: false
+  output:
+    climate_action_incentive_category:
+      - HEAD
+      - ELDEST_CHILD_IN_SINGLE_PARENT_HOUSEHOLD
+      - OTHER_CHILD
+
+- name: Single person — head only
+  period: 2026
+  input:
+    people:
+      person:
+        age: 40
+        is_head: true
+        is_spouse: false
+        employment_income: 90_000
+    households:
+      household:
+        members: [person]
+        province_code: ONT
+  output:
+    climate_action_incentive_category:
+      - HEAD

policyengine_canada/tests/gov/cra/tax/income/credits/climate_action/integration_two_parent.yaml

@@ -0,0 +1,53 @@
+- name: Two-parent household with child — household_net_income does not crash
+  period: 2026
+  absolute_error_margin: 1
+  input:
+    people:
+      parent1:
+        age: 35
+        is_head: true
+        is_spouse: false
+        employment_income: 50_000
+      parent2:
+        age: 33
+        is_head: false
+        is_spouse: true
+        employment_income: 30_000
+      child:
+        age: 5
+        is_head: false
+        is_spouse: false
+    households:
+      household:
+        members: [parent1, parent2, child]
+        province_code: ONT
+        is_married: true
+  output:
+    climate_action_incentive_category:
+      - HEAD
+      - SPOUSE
+      - OTHER_CHILD
+
+- name: Married couple no children — climate action does not crash
+  period: 2026
+  absolute_error_margin: 1
+  input:
+    people:
+      head:
+        age: 40
+        is_head: true
+        is_spouse: false
+        employment_income: 90_000
+      spouse:
+        age: 38
+        is_head: false
+        is_spouse: true
+    households:
+      household:
+        members: [head, spouse]
+        province_code: ONT
+        is_married: true
+  output:
+    climate_action_incentive_category:
+      - HEAD
+      - SPOUSE

policyengine_canada/variables/gov/cra/tax/income/credits/climate_action/climate_action_incentive_category.py

@@ -41,4 +41,5 @@ def formula(person, period, parameters):
                 ClimateActionIncentiveCategory.ELDEST_CHILD_IN_SINGLE_PARENT_HOUSEHOLD,
                 ClimateActionIncentiveCategory.OTHER_CHILD,
             ],
+            default=ClimateActionIncentiveCategory.OTHER_CHILD,
         )