Skip to content

Commit 02aa7b2

Browse files
authored
fix: db connection is now closed after fetching metadata in GenericTable (#68)
1 parent 95be339 commit 02aa7b2

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

src/utils_flask_sqla/generic.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -106,18 +106,16 @@ def __init__(self, tableName, schemaName, engine):
106106
"""
107107

108108
try:
109-
110-
conn = db.engine.connect()
111-
112-
metadata = sa.MetaData(bind=conn)
113-
self.tableDef = sa.Table(
114-
tableName,
115-
metadata,
116-
schema=schemaName,
117-
autoload_with=conn,
118-
)
109+
with db.engine.connect() as conn:
110+
metadata = sa.MetaData(bind=conn)
111+
self.tableDef = sa.Table(
112+
tableName,
113+
metadata,
114+
schema=schemaName,
115+
autoload_with=conn,
116+
)
119117
except KeyError:
120-
raise KeyError("table {}.{} doesn't exists".format(schemaName, tableName))
118+
raise KeyError("Table {}.{} doesn't exists".format(schemaName, tableName))
121119

122120
# Mise en place d'un mapping des colonnes en vue d'une sérialisation
123121
self.serialize_columns, self.db_cols = self.get_serialized_columns()

0 commit comments

Comments
 (0)