Fix MultipleChoiceItem validation and update choices to tuple

Author: PierreRaybaut

doc/release_notes/release_3.14.md

@@ -5,6 +5,7 @@
 🛠️ Bug fixes:
 
 * **Old QtPy compatibility**: Fixed `ImportError` when using QtPy < 2.0.0 (guidata supports QtPy >= 1.9) — the `PYSIDE6` constant was not available before QtPy 2.0.0
+* **MultipleChoiceItem validation**: Fixed `DataItemValidationError` when accepting a dialog containing a `MultipleChoiceItem` with validation enabled — the widget was passing a list instead of the expected tuple, causing a validation failure when closing the dialog
 
 ## guidata Version 3.14.1 ##
 

guidata/dataset/dataitems.py

@@ -1242,9 +1242,9 @@ def check_value(self, value: str, raise_exception: bool = False) -> bool:
         """Override DataItem method"""
         if not self.get_prop("data", "check_value", True):
             return True
-        if not isinstance(value, tuple):
+        if not isinstance(value, (tuple, list)):
             if raise_exception:
-                raise ValueError(f"Invalid value '{value}' (expecting tuple)")
+                raise ValueError(f"Invalid value '{value}' (expecting tuple or list)")
             return False
         for val in value:
             if val not in [v for v, _k, _i in self.get_prop("data", "choices", [])]:

guidata/dataset/qtitemwidgets.py

@@ -1297,7 +1297,7 @@ def get(self) -> None:
     def set(self) -> None:
         """Update data item value from widget contents"""
         _choices = self.item.get_prop_value("data", "choices")
-        choices = [_choices[i][0] for i in self.value()]
+        choices = tuple(_choices[i][0] for i in self.value())
         self.item.set(choices)
 
     def value(self) -> list[int]: