Remove PYHELIOS_DEV_MODE from GitHub Actions workflows

- Clean up unused `PYHELIOS_DEV_MODE` environment variable from all workflows
- Update pytest configurations to handle marker-based test skipping for platform-specific cases
- Refactor tests to consolidate cross-platform and native-only testing patterns

Author: bnbailey-psl

.github/workflows/test-linux.yml

@@ -37,21 +37,15 @@ jobs:
         pip install -e .
 
     - name: Check PyHelios installation
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         python -c "import pyhelios; print('PyHelios imported successfully')"
         python -c "from pyhelios.plugins import print_plugin_status; print_plugin_status()"
 
-    - name: Run cross-platform tests (mock mode)
-      env:
-        PYHELIOS_DEV_MODE: 1
+    - name: Run cross-platform tests
       run: |
         pytest tests/ -v -m "cross_platform or unit" --tb=short
 
     - name: Run all tests including integration (expect skips for native tests)
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         pytest tests/ -v --tb=short
 

.github/workflows/test-macos.yml

@@ -37,21 +37,15 @@ jobs:
         pip install -e .
 
     - name: Check PyHelios installation
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         python -c "import pyhelios; print('PyHelios imported successfully')"
         python -c "from pyhelios.plugins import print_plugin_status; print_plugin_status()"
 
-    - name: Run cross-platform tests (mock mode)
-      env:
-        PYHELIOS_DEV_MODE: 1
+    - name: Run cross-platform tests
       run: |
         pytest tests/ -v -m "cross_platform or unit" --tb=short
 
     - name: Run all tests including integration (expect skips for native tests)
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         pytest tests/ -v --tb=short
 

.github/workflows/test-matrix.yml

@@ -47,33 +47,23 @@ jobs:
         pip install -e .
 
     - name: Verify PyHelios installation and platform detection
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         python -c "import pyhelios; print(f'PyHelios imported successfully on {pyhelios.__name__}')"
         python -c "from pyhelios.plugins import print_plugin_status; print_plugin_status()"
 
     - name: Run cross-platform tests (should work on all platforms)
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         pytest tests/ -v -m "cross_platform" --tb=short
 
-    - name: Run unit tests (should work in mock mode)
-      env:
-        PYHELIOS_DEV_MODE: 1
+    - name: Run unit tests
       run: |
         pytest tests/ -v -m "unit" --tb=short
 
     - name: Run DataTypes tests (critical for cross-platform compatibility)
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         pytest tests/test_datatypes.py -v --tb=short
 
     - name: Run full test suite (expect skips for native tests)
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         pytest tests/ -v --tb=short
 

.github/workflows/test-quick.yml

@@ -30,26 +30,20 @@ jobs:
         pip install -e .
 
     - name: Quick smoke test
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         python -c "import pyhelios; print('✓ PyHelios imports successfully')"
         python -c "from pyhelios.plugins import print_plugin_status; print_plugin_status()"
 
     - name: Run essential tests only
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         # Run only the most critical tests for quick feedback
         pytest tests/test_datatypes.py -v --tb=short
         pytest tests/test_cross_platform.py -v -m "cross_platform" --tb=short
 
     - name: Test basic functionality
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         python -c "
-        # Test basic PyHelios functionality in mock mode
+        # Test basic PyHelios functionality 
         from pyhelios import Context, DataTypes
         
         print('Testing Context creation...')

.github/workflows/test-required.yml

@@ -36,28 +36,22 @@ jobs:
         pip install -e .
 
     - name: Verify PyHelios installation
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         python -c "import pyhelios; print(f'✓ PyHelios imported successfully')"
         python -c "from pyhelios.plugins import print_plugin_status; print_plugin_status()"
 
     - name: Run essential cross-platform tests
-      env:
-        PYHELIOS_DEV_MODE: 1
       run: |
         pytest tests/test_datatypes.py -v --tb=short
         pytest tests/test_cross_platform.py -v -m "cross_platform" --tb=short
 
-    - name: Test core functionality in mock mode
-      env:
-        PYHELIOS_DEV_MODE: 1
+    - name: Test core functionality
       run: |
         python -c "
         from pyhelios import Context, DataTypes
         from pyhelios.plugins import get_plugin_info
         
-        # Verify we start in mock mode (expected)
+        # Check what mode we're in (native or mock)
         info = get_plugin_info()
         print(f'Platform: {info[\"platform\"]}')
         print(f'Mock mode: {info[\"is_mock\"]}')

tests/conftest.py

@@ -202,4 +202,27 @@ def skip_if_no_native_library():
 
 def expect_mock_mode_error():
     """Expect a RuntimeError indicating mock mode."""
-    return pytest.raises(RuntimeError, match="mock mode")
+    return pytest.raises(RuntimeError, match="mock mode")
+
+
+def pytest_runtest_setup(item):
+    """Handle pytest marker-based test skipping."""
+    # Skip native_only tests when running in mock mode
+    if "native_only" in item.keywords:
+        if not is_native_library_available():
+            pytest.skip("Skipping native_only test - native library not available")
+    
+    # Skip requires_dll tests when running in mock mode (legacy alias)
+    if "requires_dll" in item.keywords:
+        if not is_native_library_available():
+            pytest.skip("Skipping requires_dll test - native library not available")
+    
+    # Platform-specific skips
+    if "windows_only" in item.keywords and not is_windows():
+        pytest.skip("Skipping Windows-only test on non-Windows platform")
+    
+    if "macos_only" in item.keywords and not is_macos():
+        pytest.skip("Skipping macOS-only test on non-macOS platform")
+    
+    if "linux_only" in item.keywords and not is_linux():
+        pytest.skip("Skipping Linux-only test on non-Linux platform")

tests/test_external_geometry.py

@@ -312,18 +312,16 @@ class TestPrimitiveInfo:
 
     def test_get_primitive_info_mock(self):
         """Test getting primitive information with mocked data."""
-        with patch.multiple(
-            'pyhelios.Context.Context',
-            getPrimitiveType=Mock(return_value=DataTypes.PrimitiveType.Triangle),
-            getPrimitiveArea=Mock(return_value=0.5),
-            getPrimitiveNormal=Mock(return_value=DataTypes.vec3(0, 0, 1)),
-            getPrimitiveVertices=Mock(return_value=[
+        with patch.object(Context, 'getPrimitiveType', return_value=DataTypes.PrimitiveType.Triangle), \
+             patch.object(Context, 'getPrimitiveArea', return_value=0.5), \
+             patch.object(Context, 'getPrimitiveNormal', return_value=DataTypes.vec3(0, 0, 1)), \
+             patch.object(Context, 'getPrimitiveVertices', return_value=[
                 DataTypes.vec3(0, 0, 0),
-                DataTypes.vec3(1, 0, 0),
+                DataTypes.vec3(1, 0, 0), 
                 DataTypes.vec3(0, 1, 0)
-            ]),
-            getPrimitiveColor=Mock(return_value=DataTypes.RGBcolor(1, 0, 0))
-        ):
+             ]), \
+             patch.object(Context, 'getPrimitiveColor', return_value=DataTypes.RGBcolor(1, 0, 0)):
+            
             context = Context()
 
             info = context.getPrimitiveInfo(123)
@@ -384,20 +382,21 @@ class TestPrimitiveDataAPI:
     """Test primitive data API (placeholders until C++ wrappers implemented)."""
 
     def test_primitive_data_methods_not_implemented(self):
-        """Test that primitive data methods raise NotImplementedError."""
+        """Test that primitive data methods raise appropriate errors."""
         context = Context()
 
-        # All primitive data methods should raise NotImplementedError
-        with pytest.raises(NotImplementedError):
+        # In mock mode, these should raise RuntimeError about mock mode
+        # In native mode without implementation, they should raise NotImplementedError
+        with pytest.raises((NotImplementedError, RuntimeError)):
             context.setPrimitiveData(1, "test_key", 42)
 
-        with pytest.raises(NotImplementedError):
+        with pytest.raises((NotImplementedError, RuntimeError)):
             context.getPrimitiveData(1, "test_key", int)
 
-        with pytest.raises(NotImplementedError):
+        with pytest.raises((NotImplementedError, RuntimeError)):
             context.doesPrimitiveDataExist(1, "test_key")
 
-        with pytest.raises(NotImplementedError):
+        with pytest.raises((NotImplementedError, RuntimeError)):
             context.getPrimitiveDataLabels(1)
 
 

tests/test_radiation_model.py

@@ -17,10 +17,10 @@
 from pyhelios.RadiationModel import RadiationSourceType
 
 
+@pytest.mark.native_only
 class TestRadiationModel:
     """Test RadiationModel class functionality"""
 
-    @pytest.mark.cross_platform
     def test_radiation_model_creation(self):
         """Test RadiationModel creation and destruction"""
         with Context() as context:
@@ -37,7 +37,6 @@ def test_radiation_model_invalid_context(self):
         with pytest.raises(TypeError):
             RadiationModel("invalid_context")
 
-    @pytest.mark.cross_platform
     def test_message_control(self):
         """Test message enable/disable functionality"""
         with Context() as context:
@@ -46,7 +45,6 @@ def test_message_control(self):
                 radiation_model.disableMessages()
                 radiation_model.enableMessages()
 
-    @pytest.mark.cross_platform
     def test_radiation_bands(self):
         """Test radiation band management"""
         with Context() as context:
@@ -60,7 +58,6 @@ def test_radiation_bands(self):
                 # Copy radiation band
                 radiation_model.copyRadiationBand("SW", "SW_copy")
 
-    @pytest.mark.cross_platform
     def test_radiation_sources(self):
         """Test radiation source creation"""
         with Context() as context:
@@ -89,7 +86,6 @@ def test_radiation_sources(self):
                     spherical_dir, 1.0, 0.00935, 1.0)
                 assert isinstance(source5, int)
 
-    @pytest.mark.cross_platform
     def test_radiation_source_invalid_direction(self):
         """Test radiation source creation with invalid direction type"""
         with Context() as context:
@@ -110,7 +106,6 @@ def test_ray_count_configuration(self):
                 # Set diffuse ray count
                 radiation_model.setDiffuseRayCount("SW", 300)
 
-    @pytest.mark.cross_platform
     def test_flux_configuration(self):
         """Test flux configuration"""
         with Context() as context:
@@ -132,7 +127,6 @@ def test_flux_configuration(self):
                 flux = radiation_model.getSourceFlux(source, "SW")
                 assert isinstance(flux, float)
 
-    @pytest.mark.cross_platform
     def test_flux_configuration_invalid_types(self):
         """Test flux configuration with invalid types"""
         with Context() as context:
@@ -142,7 +136,6 @@ def test_flux_configuration_invalid_types(self):
                 with pytest.raises(TypeError):
                     radiation_model.setSourceFlux("invalid_source", "SW", 800.0)
 
-    @pytest.mark.cross_platform
     def test_scattering_configuration(self):
         """Test scattering configuration"""
         with Context() as context:
@@ -155,7 +148,6 @@ def test_scattering_configuration(self):
                 # Set minimum scatter energy
                 radiation_model.setMinScatterEnergy("SW", 0.01)
 
-    @pytest.mark.cross_platform
     def test_emission_control(self):
         """Test emission control"""
         with Context() as context:
@@ -168,7 +160,6 @@ def test_emission_control(self):
                 # Enable emission
                 radiation_model.enableEmission("SW")
 
-    @pytest.mark.cross_platform
     def test_geometry_update(self):
         """Test geometry update"""
         with Context() as context:
@@ -182,7 +173,6 @@ def test_geometry_update(self):
                 # Update specific geometry
                 radiation_model.updateGeometry([patch])
 
-    @pytest.mark.cross_platform
     def test_run_simulation_basic(self):
         """Test basic simulation execution (should not crash in mock mode)"""
         with Context() as context:
@@ -204,15 +194,13 @@ def test_run_simulation_basic(self):
                 radiation_model.addRadiationBand("LW")
                 radiation_model.runBand(["SW", "LW"])
 
-    @pytest.mark.cross_platform
     def test_run_simulation_invalid_types(self):
         """Test simulation with invalid label types"""
         with Context() as context:
             with RadiationModel(context) as radiation_model:
                 with pytest.raises(TypeError):
                     radiation_model.runBand(123)  # Invalid type
 
-    @pytest.mark.cross_platform
     def test_result_access(self):
         """Test accessing simulation results"""
         with Context() as context:
@@ -234,10 +222,10 @@ def test_result_access(self):
                 assert band_count >= 0
 
 
+@pytest.mark.native_only
 class TestContextPseudocolor:
     """Test Context pseudocolor functionality"""
 
-    @pytest.mark.cross_platform
     def test_pseudocolor_basic(self):
         """Test basic pseudocolor functionality"""
         with Context() as context:
@@ -256,7 +244,6 @@ def test_pseudocolor_basic(self):
                 # Expected in mock mode when pseudocolor functions are not available
                 pass
 
-    @pytest.mark.cross_platform
     def test_pseudocolor_with_range(self):
         """Test pseudocolor with specified range"""
         with Context() as context:
@@ -275,7 +262,6 @@ def test_pseudocolor_with_range(self):
                 # Expected in mock mode when pseudocolor functions are not available
                 pass
 
-    @pytest.mark.cross_platform
     def test_pseudocolor_different_colormaps(self):
         """Test different colormap options"""
         with Context() as context: