1. BUILD_SHARED_LIBS=OFF will prevent zlib from creating its problematic shared library target

  2. zlib will only build zlibstatic (which doesn't have resource compilation issues)
  3. pyhelios_shared will still be explicitly created as a shared library because it's defined as
   SHARED in the CMakeLists.txt
  4. All dependencies will be statically linked into the PyHelios DLL

  Add pyyaml as dependency in requirements.txt

Author: bnbailey-psl

.github/workflows/pytest-linux.yml

@@ -30,7 +30,6 @@ jobs:
     - name: Install build dependencies only
       run: |
         python -m pip install --upgrade pip
-        pip install pyyaml
         
     - name: Build native libraries
       run: |

.github/workflows/pytest-macos.yml

@@ -28,7 +28,6 @@ jobs:
     - name: Install build dependencies only
       run: |
         python -m pip install --upgrade pip
-        pip install pyyaml
         
     - name: Build native libraries
       run: |

.github/workflows/pytest-windows.yml

@@ -27,7 +27,6 @@ jobs:
     - name: Install build dependencies only
       run: |
         python -m pip install --upgrade pip
-        pip install pyyaml
         
     - name: Build native libraries
       run: |

build_scripts/build_helios.py

@@ -506,16 +506,16 @@ def run_cmake_configure(self, additional_args: Optional[List[str]] = None) -> No
             cmake_cmd.extend(additional_args)
 
         # Add PyHelios-specific options
-        cmake_cmd.extend([
-            '-DBUILD_SHARED_LIBS=ON',  # Build as shared library
-        ])
-        
-        # Windows-specific workaround for zlib resource compilation issue
-        # The RC compiler fails on win32/zlib1.rc due to C syntax in included headers
-        # Disable resource compilation by not setting CMAKE_RC_COMPILER
         if self.platform_name == 'Windows':
+            # Windows-specific workaround for zlib resource compilation issue
+            # The RC compiler fails on win32/zlib1.rc due to C syntax in included headers  
+            # Force static builds to avoid zlib RC issues, but manually create PyHelios shared lib
+            cmake_cmd.extend([
+                '-DBUILD_SHARED_LIBS=OFF',  # Force static builds to avoid zlib RC errors
+            ])
+        else:
             cmake_cmd.extend([
-                '-DCMAKE_RC_COMPILER=',  # Disable resource compiler to avoid RC1106 errors
+                '-DBUILD_SHARED_LIBS=ON',  # Build as shared library on non-Windows
             ])
 
         print(f"Running CMake configure: {' '.join(cmake_cmd)}")

requirements.txt

@@ -1 +1,2 @@
-numpy>=1.19.0
+numpy>=1.19.0
+pyyaml>=5.0.0