CI typecheck

Author: neoneye

.github/workflows/ci.yml

@@ -66,17 +66,43 @@ jobs:
     name: typecheck
     runs-on: ubuntu-latest
     continue-on-error: true
-    timeout-minutes: 20
+    timeout-minutes: 35
 
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Set up Python 3.13
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+          cache: "pip"
+          cache-dependency-path: |
+            worker_plan/pyproject.toml
+            frontend_multi_user/pyproject.toml
+            frontend_single_user/requirements.txt
+            worker_plan_database/requirements.txt
+            open_dir_server/requirements.txt
+
       - name: Set up Node
         uses: actions/setup-node@v4
         with:
           node-version: "22"
 
+      - name: Prepare Python environment for pyright
+        run: |
+          python -m venv .venv
+          .venv/bin/python -m pip install --upgrade pip
+          .venv/bin/pip install -e worker_plan
+          .venv/bin/pip install -e frontend_multi_user
+          .venv/bin/pip install -r frontend_single_user/requirements.txt
+          .venv/bin/pip install -r worker_plan_database/requirements.txt
+          .venv/bin/pip install -r open_dir_server/requirements.txt
+          ln -sfn ../.venv frontend_multi_user/.venv
+          ln -sfn ../.venv frontend_single_user/.venv
+          ln -sfn ../.venv worker_plan_database/.venv
+          ln -sfn ../.venv open_dir_server/.venv
+
       - name: Install pyright
         run: npm install -g pyright
 

frontend_multi_user/src/app.py

@@ -1168,12 +1168,18 @@ def _normalize_plan_view_mode(value: Any) -> str:
             return mode
         return "view"
 
+    @staticmethod
+    def _coerce_json_dict(value: Any) -> dict[str, Any]:
+        if not isinstance(value, dict):
+            return {}
+        return {str(key): item for key, item in value.items()}
+
     def _get_plan_view_mode_preference(self) -> str:
         user = self._get_current_user_account()
         if user is None:
             return "view"
-        config = user.frontend_multi_user_config if isinstance(user.frontend_multi_user_config, dict) else {}
-        plan_page = config.get("plan_page") if isinstance(config.get("plan_page"), dict) else {}
+        config = self._coerce_json_dict(user.frontend_multi_user_config)
+        plan_page = self._coerce_json_dict(config.get("plan_page"))
         return self._normalize_plan_view_mode(plan_page.get("selected_segment"))
 
     def _set_plan_view_mode_preference(self, mode: str) -> None:
@@ -1183,9 +1189,9 @@ def _set_plan_view_mode_preference(self, mode: str) -> None:
         normalized_mode = self._normalize_plan_view_mode(mode)
         # JSON columns are not mutation-tracked by default; build fresh dicts so
         # SQLAlchemy sees a new value and persists the update reliably.
-        existing_config = user.frontend_multi_user_config if isinstance(user.frontend_multi_user_config, dict) else {}
+        existing_config = self._coerce_json_dict(user.frontend_multi_user_config)
         config = dict(existing_config)
-        existing_plan_page = config.get("plan_page") if isinstance(config.get("plan_page"), dict) else {}
+        existing_plan_page = self._coerce_json_dict(config.get("plan_page"))
         plan_page = dict(existing_plan_page)
         plan_page["selected_segment"] = normalized_mode
         config["plan_page"] = plan_page
@@ -1547,7 +1553,7 @@ def _build_plan_failure_trace(self, task: TaskItem) -> dict[str, Any]:
 
         return failure_trace
 
-    def _build_plan_telemetry_cache_key(self, task: TaskItem, include_raw: bool) -> Optional[tuple[str, str, bool]]:
+    def _build_plan_telemetry_cache_key(self, task: TaskItem, include_raw: bool) -> Optional[tuple[str, str, bool, bool]]:
         state = task.state if isinstance(task.state, TaskState) else None
         if include_raw or state not in (TaskState.completed, TaskState.failed):
             return None
@@ -1969,7 +1975,7 @@ def inject_current_user_name():
         @self.app.route('/')
         def index():
             user = None
-            recent_tasks: list[TaskItem] = []
+            recent_tasks: list[SimpleNamespace] = []
             total_tasks_count = 0
             is_admin = False
             nonce = None

frontend_multi_user/tests/test_plan_failure_trace_helpers.py

@@ -5,6 +5,7 @@
 import unittest
 import zipfile
 from pathlib import Path
+from typing import Any
 
 
 PROJECT_ROOT = Path(__file__).resolve().parents[2]
@@ -23,19 +24,21 @@
 
 APP_MODULE_PATH = FRONTEND_SRC / "app.py"
 APP_IMPORT_ERROR = None
-MyFlaskApp = None
+APP_AVAILABLE = False
+MyFlaskApp: type[Any] = object
 try:
     APP_SPEC = importlib.util.spec_from_file_location("frontend_multi_user_app", APP_MODULE_PATH)
     if APP_SPEC is None or APP_SPEC.loader is None:
         raise RuntimeError(f"Unable to load app module at {APP_MODULE_PATH}")
     frontend_app_module = importlib.util.module_from_spec(APP_SPEC)
     APP_SPEC.loader.exec_module(frontend_app_module)
     MyFlaskApp = frontend_app_module.MyFlaskApp
+    APP_AVAILABLE = True
 except ModuleNotFoundError as exc:
     APP_IMPORT_ERROR = exc
 
 
-@unittest.skipIf(MyFlaskApp is None, f"frontend_multi_user app dependencies unavailable: {APP_IMPORT_ERROR}")
+@unittest.skipIf(not APP_AVAILABLE, f"frontend_multi_user app dependencies unavailable: {APP_IMPORT_ERROR}")
 class TestPlanFailureTraceHelpers(unittest.TestCase):
     def setUp(self) -> None:
         self.app_obj = MyFlaskApp.__new__(MyFlaskApp)

frontend_multi_user/tests/test_plan_telemetry_helpers.py

@@ -7,6 +7,7 @@
 from datetime import UTC, datetime
 from pathlib import Path
 from types import SimpleNamespace
+from typing import Any
 from unittest import mock
 
 
@@ -26,8 +27,9 @@
 
 APP_MODULE_PATH = FRONTEND_SRC / "app.py"
 APP_IMPORT_ERROR = None
-MyFlaskApp = None
-TaskState = None
+APP_AVAILABLE = False
+MyFlaskApp: type[Any] = object
+TaskState: Any = SimpleNamespace(processing="processing", completed="completed")
 frontend_app_module = None
 try:
     APP_SPEC = importlib.util.spec_from_file_location("frontend_multi_user_app", APP_MODULE_PATH)
@@ -37,11 +39,12 @@
     APP_SPEC.loader.exec_module(frontend_app_module)
     MyFlaskApp = frontend_app_module.MyFlaskApp
     TaskState = frontend_app_module.TaskState
+    APP_AVAILABLE = True
 except ModuleNotFoundError as exc:
     APP_IMPORT_ERROR = exc
 
 
-@unittest.skipIf(MyFlaskApp is None, f"frontend_multi_user app dependencies unavailable: {APP_IMPORT_ERROR}")
+@unittest.skipIf(not APP_AVAILABLE, f"frontend_multi_user app dependencies unavailable: {APP_IMPORT_ERROR}")
 class TestPlanTelemetryHelpers(unittest.TestCase):
     class _DummyColumn:
         def asc(self):