Skip to content

nonce is not inserted when creating ppms.js script tag #58

@aximusnl

Description

@aximusnl

Piwik is inserting the following script:

<script type="text/javascript">
    try {
      
    var _paq = _paq || [];
    _paq.push(['setTrackingSource', 'jstc_tm']);
    _paq.push(['enableLinkTracking']);
    _paq.push(['setIpTracking', true]);
    _paq.push(['setDomains', ['my-domain.com']]);
    _paq.push(['trackPageView']);
    _paq.push(['enableJSErrorTracking']);
    (function(p,i,w,ik) {
        var g=ik.createElement('script'),s=ik.getElementsByTagName('script')[0];
        _paq.push(['setTrackerUrl', p]);
        _paq.push(['setSiteId', w]);
        g.type='text/javascript';g.async=true;g.defer=true;g.src=i;s.parentNode.insertBefore(g,s);
    })('https://some-piwikpro-domain.com/ppms.php','https://some-piwikpro-domain.com/ppms.js','XXXXXX',document)

    } catch (error) {
      console.error('Failed to evaluate tag - ' + "Piwik PRO" + ': ' + error.message)      
    }
</script>

This script is given the correct nonce by rewriteScriptElement.

But the script it inserts is creating a new script (var g = ik.createElement('script')) which should also be given the correct nonce.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions