Skip to content

Commit 7ea9130

Browse files
fix(scripts): update ticdc publishing threshold to v8.5.4 (#3920)
This pull request updates the version gating logic for the `pingcap/ticdc` repository across several release and artifact management scripts. The main change is shifting the version threshold for including or initializing `pingcap/ticdc` from `v9.0.0` down to `v8.5.4`, ensuring that relevant scripts and processes now handle `pingcap/ticdc` starting from version `v8.5.4` instead of `v9.0.0`. **Version threshold updates for `pingcap/ticdc`:** * Updated the version check in `tag-oci-artifact-repos.sh` and `tag-oci-image-repos.sh` to include `pingcap/ticdc` starting from `v8.5.4` instead of `v9.0.0`. [[1]](diffhunk://#diff-5f9f22aa348dee8655c74d49a698358118e4321614f6f8664709a3d09190f81eL54-R55) [[2]](diffhunk://#diff-5f9f22aa348dee8655c74d49a698358118e4321614f6f8664709a3d09190f81eL118-R119) * Changed the comment and logic in `collect-info-for-release-issue.sh` to reflect that `pingcap/ticdc` is included since `v8.5.4`. * Adjusted the initialization logic for `pingcap/ticdc` in `check-images-internal.ts` and `check-tiup.ts` to use `v8.5.4` as the threshold. [[1]](diffhunk://#diff-bda2ba3d75043b6dba98a83474bb05cfa4d2a70bc74440c0f32f88ee9c6f6fb9L158-R158) [[2]](diffhunk://#diff-0be4c32d0693a4c6b794b5c07c45baa7f15e5e76ffeb8cbe37d9ba30456653b9L223-R224) **Release version updates:** * Updated the `previous_release` and `current_release` variables in `collect-info-for-release-issue.sh` to `v8.5.3` and `v8.5.4` respectively. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 2703250 commit 7ea9130

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

scripts/artifacts/tag-rc2ga-on-repos.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ function tag_oci_artifact_repos() {
5151
"pingcap/tidb-binlog/package"
5252
)
5353
fi
54-
# pingcap/ticdc/package published since v9.0.0
55-
if [[ "$(printf '%s\n' "v9.0.0" "$ga_ver" | sort -V | head -n1)" == "v9.0.0" ]]; then
54+
# pingcap/ticdc/package published since v8.5.4
55+
if [[ "$(printf '%s\n' "v8.5.4" "$ga_ver" | sort -V | tail -n1)" == "$ga_ver" ]]; then
5656
repos+=(
5757
"pingcap/ticdc/package"
5858
)
@@ -115,8 +115,8 @@ function tag_oci_image_repos() {
115115
"pingcap/tidb-binlog/image"
116116
)
117117
fi
118-
# ticdc will publish from ticdc repo since v9.0.0
119-
if [[ "$(printf '%s\n' "v9.0.0" "$ga_ver" | sort -V | head -n1)" == "v9.0.0" ]]; then
118+
# ticdc will publish from ticdc repo since v8.5.4
119+
if [[ "$(printf '%s\n' "v8.5.4" "$ga_ver" | sort -V | tail -n1)" == "$ga_ver" ]]; then
120120
# remove "pingcap/tiflow/images/cdc":
121121
images=("${images[@]/pingcap\/tiflow\/images\/cdc/}")
122122
# Filter out empty elements that might result from the removal

scripts/flow/ga/collect-info-for-release-issue.sh

100644100755
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#! /usr/bin/env bash
22
# This script collects information about the current release and generates markdown for release issues.
33

4-
previous_release="v8.5.1" # comment it when current release is not a patch release.
5-
current_release="v8.5.2"
4+
previous_release="v8.5.3" # comment it when current release is not a patch release.
5+
current_release="v8.5.4"
66

77
### !!! Please update the list of repositories before running this script.
88
repos=(
@@ -15,7 +15,7 @@ repos=(
1515
pingcap/ng-monitoring
1616
pingcap/tidb-dashboard
1717

18-
pingcap/ticdc # started since v9.0.0
18+
pingcap/ticdc # started since v8.5.4
1919
pingcap/tidb-tools # migrated to pingcap/tiflow since v9.0.0
2020
pingcap/tidb-binlog # deprecated since v8.3.0
2121
)

scripts/flow/rc/check-images-internal.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ async function checkImages(
155155
if (version >= "v8.4.0" && gitRepo === "pingcap/tidb-binlog") {
156156
continue;
157157
}
158-
// ticdc is initilized since v9.0.0
158+
// ticdc is initilized since v8.5.4
159159
if (version <= "v8.5.3" && gitRepo === "pingcap/ticdc") {
160160
continue;
161161
}

scripts/flow/rc/check-tiup.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ async function main(
220220
if (version >= "v8.4.0" && ociRepo === "pingcap/tidb-binlog/package") {
221221
continue;
222222
}
223-
// ticdc is initilized since v9.0.0
224-
if (version <= "v9.0.0" && ociRepo === "pingcap/ticdc/package") {
223+
// ticdc is initilized since v8.5.4
224+
if (version < "v8.5.4" && ociRepo === "pingcap/ticdc/package") {
225225
continue;
226226
}
227227

0 commit comments

Comments
 (0)