getfile error

[nfr25]

I'm using PySide, python 2.7, 32 bit on windows.
I get an error in getfile of FileLayout because the return value of QfileDialog.getOpenFileName is a tuple.
I've added the following test

       if name:
            if type(name) is tuple:
                name = name[0]
            self.lineedit.setText(name)

I also propose to replace the 'Browse' button in FileLayout, like this 👍

    self.filebtn = QPushButton('...')
    self.filebtn.setFixedSize(20, 20)

[fgallaire]

Hello, we were thinking to drop the PySide support. Why do you prefer PySide over PyQt ?

[nfr25]

Hello, I was under the impression that pyside is free and pyqt Is not. Am i wrong? Le 27 mars 2017 02:20, "Florent Gallaire" <notifications@github.com> a écrit :

…

Hello, we were thinking to drop the PySide support. Why do you prefer PySide over PyQt ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZakzzavOuHhZkKGiKEOTIevFcBI61ZGks5rpwDdgaJpZM4MoGCT> .

[fgallaire]

pyside is free and pyqt Is not. Am i wrong?

Yes you are. PySide and PyQt are both free software, but use different free licenses.

[nfr25]

Anyway, I like Pyside, it serve me well. Please don't drop support to it. Thank you.

…

On 27 March 2017 at 13:52, Florent Gallaire ***@***.***> wrote: pyside is free and pyqt Is not. Am i wrong? Yes you are. PySide and PyQt are both free software, but use different free licenses. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZakz-DqcAG-lrdsCCjHLGqtFC7TlkDzks5rp6LugaJpZM4MoGCT> .

-- Noël Frankinet Strategis sprl 0478/90.92.54

[fgallaire]

@nfr25 could you do a Pull Request with your fix ?

[nfr25]

How do I do that ?

…

On 27 March 2017 at 23:43, Florent Gallaire ***@***.***> wrote: Heelo, could you do a Pull Request with your fix ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#86 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZakz91v-ENl2sz2_8_gZ40acedwezToks5rqC2XgaJpZM4MoGCT> .

-- Noël Frankinet Strategis sprl 0478/90.92.54

[nfr25]

Hello again, I've done a Git clone, edited my correction, git add, git commit. But For Git push, I need a login/password. May I get one, or is there another way ? Best regards Noël

…

On 4 April 2017 at 09:23, Noel Frankinet ***@***.***> wrote: How do I do that ? On 27 March 2017 at 23:43, Florent Gallaire ***@***.***> wrote: > Heelo, could you do a Pull Request with your fix ? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#86 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AZakz91v-ENl2sz2_8_gZ40acedwezToks5rqC2XgaJpZM4MoGCT> > . > -- Noël Frankinet Strategis sprl 0478/90.92.54

-- Noël Frankinet Strategis sprl 0478/90.92.54

[fgallaire]

@nfr25 first you need to fork the repo to your own one and doing your modifications in it. After that you must use your GitHub login/password, this will commit to your GitHub fork, then make a Pull Request.