pp_pack: unpack: Use 'uv' form, not 'uvchr'

khwilliamson · khwilliamson · commit b4df558f5378 · 2025-08-19T18:07:33.000-06:00
The new form croaks under failure; the previous didn't.  But to get here
the previous paragraph of code had to succeed, which means this should
too.

The flag in the changed call is the default for utf8_to_uv_or_die(), so
it can be removed.
diff --git a/pp_pack.c b/pp_pack.c
@@ -1322,8 +1322,7 @@ S_unpack_rec(pTHX_ tempsym_t* symptr, const char *s, const char *strbeg, const c
                         break;
                     }
 
-                    auv = utf8n_to_uvchr(result, len, &retlen,
-                                         UTF8_ALLOW_DEFAULT);
+                    auv = utf8_to_uv_or_die(result, result + len, &retlen);
                     s = ptr;
                 }
                 else {

Original file line number	Diff line number	Diff line change
`@@ -1322,8 +1322,7 @@ S_unpack_rec(pTHX_ tempsym_t* symptr, const char s, const char strbeg, const c`
`1322`	`1322`	`break;`
`1323`	`1323`	`}`
`1324`	`1324`
`1325`		`- auv = utf8n_to_uvchr(result, len, &retlen,`
`1326`		`- UTF8_ALLOW_DEFAULT);`
	`1325`	`+ auv = utf8_to_uv_or_die(result, result + len, &retlen);`
`1327`	`1326`	`s = ptr;`
`1328`	`1327`	`}`
`1329`	`1328`	`else {`