From 1b989496c5eb7f5fc5bcd4f9eeaad7d85cbace79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io>
Date: Wed, 15 Oct 2025 10:59:11 -0300
Subject: [PATCH 1/2] =?UTF-8?q?[#24]=C2=A0Regression=20tests?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 t/rfc5322-compliance.t | 50 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100755 t/rfc5322-compliance.t

diff --git a/t/rfc5322-compliance.t b/t/rfc5322-compliance.t
new file mode 100755
index 0000000..4119f16
--- /dev/null
+++ b/t/rfc5322-compliance.t
@@ -0,0 +1,50 @@
+#!/usr/bin/env perl
+use strict;
+use warnings;
+use Test::More;
+use Email::Address;
+
+# Regression test for RFC 5322 compliance issue found in Koha
+# Email::Address should reject addresses without proper TLD per RFC 5322
+
+# Test addresses that should be INVALID (missing TLD)
+my @invalid_addresses = (
+    'test@gmail',
+    'admin@server',
+    'user@domain',
+);
+
+# Test addresses that should be VALID (proper FQDN)
+my @valid_addresses = (
+    'test@gmail.com',
+    'user@localhost',  # localhost is a special case that may be valid
+    'admin@server.example.com',
+);
+
+# Test that invalid addresses are rejected
+for my $addr (@invalid_addresses) {
+    my @parsed = Email::Address->parse($addr);
+    is(scalar(@parsed), 0, "$addr should be rejected (missing TLD)");
+}
+
+# Test that valid addresses are accepted
+for my $addr (@valid_addresses) {
+    my @parsed = Email::Address->parse($addr);
+    is(scalar(@parsed), 1, "$addr should be accepted (valid FQDN)");
+}
+
+done_testing();
+
+__END__
+
+=head1 NAME
+
+rfc5322-compliance.t - Regression test for RFC 5322 compliance
+
+=head1 DESCRIPTION
+
+This test ensures Email::Address properly rejects email addresses that violate
+RFC 5322 by lacking fully qualified domain names (FQDN).
+
+Currently FAILS because Email::Address incorrectly accepts addresses like
+'test@gmail' when they should be rejected per RFC 5322.

From 383acf6085f9bd59559705afa7e8e7a8c22dadb8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io>
Date: Wed, 15 Oct 2025 10:59:50 -0300
Subject: [PATCH 2/2] [#24] Consider invalid TLD invalid

This patch changes the regex for TLD validation so it requires at least
one dot, with the exception of `localhost`

To test:
1. Pick the regression tests patch
2. Run:
   $ prove t/rfc5322-compliance.t
=> FAIL: Tests fail! Invalid addresses are considered valid. Boo!
3. Pick this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Accept this patch :-D
---
 lib/Email/Address.pm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/Email/Address.pm b/lib/Email/Address.pm
index f642b77..7fe1deb 100644
--- a/lib/Email/Address.pm
+++ b/lib/Email/Address.pm
@@ -54,7 +54,11 @@ my $cfws           = qr/$comment|(?>\s+)/;
 my $atext          = qq/[^$CTL$special\\s]/;
 my $atom           = qr/(?>$cfws*$atext+$cfws*)/;
 my $dot_atom_text  = qr/(?>$atext+(?:\.$atext+)*)/;
+my $fqdn_atom_text = qr/(?>$atext+\.$atext+(?:\.$atext+)*)/;  # Requires at least one dot
+my $localhost_text = qr/localhost/i;
 my $dot_atom       = qr/(?>$cfws*$dot_atom_text$cfws*)/;
+my $fqdn_atom      = qr/(?>$cfws*$fqdn_atom_text$cfws*)/;
+my $localhost_atom = qr/(?>$cfws*$localhost_text$cfws*)/;
 
 my $qtext          = qr/[^\\"]/;
 my $qcontent       = qr/$qtext|$quoted_pair/;
@@ -83,7 +87,7 @@ my $local_part     = qr/$dot_atom|$quoted_string/;
 my $dtext          = qr/[^\[\]\\]/;
 my $dcontent       = qr/$dtext|$quoted_pair/;
 my $domain_literal = qr/(?>$cfws*\[(?:\s*$dcontent)*\s*\]$cfws*)/;
-my $domain         = qr/$dot_atom|$domain_literal/;
+my $domain         = qr/$fqdn_atom|$localhost_atom|$domain_literal/;
 
 my $display_name   = $phrase;