[BUG]-DM USB Input - Input routing not selecting the correct card

[andrew-welker]

Was this bug identified in a specific build version?
1.10.0

Describe the bug
The outputSelector value is being used to determine the input card value instead of the input selector value

Offending code:

if ((sigType & eRoutingSignalType.UsbInput) == eRoutingSignalType.UsbInput)
            {
                Debug.Console(2, this, "Executing USB Input switch.\r\n in:{0} output: {1}", inputSelector, outputSelector);
                if (outputSelector > chassisSize)
                {
                    uint outputIndex;

                    if (chassisSize == 8)
                    {
                        outputIndex = (uint) inputSelector - 16;
                    }
                    else
                    {
                        outputIndex = inputSelector - chassisSize;
                    }
                    dmCard = Chassis.Outputs[outputIndex];
                }
                else
                {
                    dmCard = Chassis.Inputs[inputSelector];
                }

                ExecuteSwitch(dmCard, Chassis.Inputs[outputSelector], sigType);
                return;
            }

[jtalborough]

@andrew-welker Has this been fixed?

[cdenig]

@andrew-welker I confirm this issue was still present in v1.5.4 and have a field-tested fix in place under branch
fix-usb-switch-null-ref