From a7d100b11c844bdd232478d3eef4b734da4eea8e Mon Sep 17 00:00:00 2001 From: Maciej Jalocha Date: Thu, 19 Dec 2024 02:58:20 +0100 Subject: [PATCH 1/6] format(model_selection): to follow line-length --- github_dagger_workflow_project/03_model_selection.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/github_dagger_workflow_project/03_model_selection.py b/github_dagger_workflow_project/03_model_selection.py index 0e1f44d..0f7a759 100644 --- a/github_dagger_workflow_project/03_model_selection.py +++ b/github_dagger_workflow_project/03_model_selection.py @@ -33,7 +33,8 @@ def save_best_model(experiment_best, best_model_type) -> None: experiment_best = select_best_model(experiment_name) # Save best model -# Currently we pick only LR, no matter what the best model is. When ready, uncomment to consider xgboost. +# Currently we pick only LR, no matter what the best model is. +# When ready, uncomment to consider xgboost. # best_model_type = experiment_best["params.model_type"] # and comment below code best_model_type = "LogisticRegression" From 64120e84d99d3f473a01939ba7b6ba5e6134b6a6 Mon Sep 17 00:00:00 2001 From: Maciej Jalocha Date: Thu, 19 Dec 2024 02:58:42 +0100 Subject: [PATCH 2/6] chore: explicitly enforce pep8 warns & errs --- pyproject.toml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pyproject.toml b/pyproject.toml index dec64dd..feebd4e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -37,5 +37,10 @@ ignore = [ "ISC001", # single-line-implicit-string-concatenation ] +select = [ +"E", # PEP 8 Errors +"W", # PEP 8 warnings +] + From 49a13c932b6a345096641129a2d5e524014824e6 Mon Sep 17 00:00:00 2001 From: Maciej Jalocha Date: Thu, 19 Dec 2024 03:02:22 +0100 Subject: [PATCH 3/6] chore: add go mod download to make setup --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index dd6e3ca..83c254c 100644 --- a/Makefile +++ b/Makefile @@ -6,6 +6,7 @@ all: setup test .PHONY: setup setup: venv $(VENV)/pre-commit install + go mod download .PHONY: test test: From af72e43092391e84a272cc923c125bec537c19c9 Mon Sep 17 00:00:00 2001 From: Maciej Jalocha Date: Thu, 19 Dec 2024 03:02:42 +0100 Subject: [PATCH 4/6] chore: add make script for container_run --- Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 83c254c..24b240c 100644 --- a/Makefile +++ b/Makefile @@ -10,4 +10,7 @@ setup: venv .PHONY: test test: - dagger run go test -v \ No newline at end of file + dagger run go test -v + +.PHONY: container_run + dagger run go run pipeline.go \ No newline at end of file From 46da34346fa8b3a11848678eb2b53af498a89315 Mon Sep 17 00:00:00 2001 From: Maciej Jalocha Date: Thu, 19 Dec 2024 03:12:31 +0100 Subject: [PATCH 5/6] ci: fix use Lasse's path --- .github/workflows/test_action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test_action.yml b/.github/workflows/test_action.yml index 2c30d80..8f79db9 100644 --- a/.github/workflows/test_action.yml +++ b/.github/workflows/test_action.yml @@ -33,7 +33,7 @@ jobs: with: name: all-artifacts path: artifacts/ - + - name: Upload Best Model Artifact uses: actions/upload-artifact@v4.4.0 with: @@ -46,7 +46,7 @@ jobs: with: path: ./ depth: 3 - + test_model: needs: train_and_upload name: Unit Test Model Artifacts @@ -80,4 +80,4 @@ jobs: echo "All required files are present." - name: Run Model Inference Test Action - uses: PLtier/itu-sdse-project-model-validator@main + uses: lasselundstenjensen/itu-sdse-project-model-validator@main From d4f6378606f063d78c739192c9869f20e8191bf7 Mon Sep 17 00:00:00 2001 From: Maciej Jalocha Date: Thu, 19 Dec 2024 03:15:20 +0100 Subject: [PATCH 6/6] ci: remove printing tree --- .github/workflows/test_action.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/test_action.yml b/.github/workflows/test_action.yml index 8f79db9..551dbc5 100644 --- a/.github/workflows/test_action.yml +++ b/.github/workflows/test_action.yml @@ -40,13 +40,6 @@ jobs: name: model path: artifacts/model.pkl - - name: tree - uses: jaywcjlove/github-action-folder-tree@main - id: tree - with: - path: ./ - depth: 3 - test_model: needs: train_and_upload name: Unit Test Model Artifacts