diff --git a/.github/workflows/test_action.yml b/.github/workflows/test_action.yml index 2c30d80..551dbc5 100644 --- a/.github/workflows/test_action.yml +++ b/.github/workflows/test_action.yml @@ -33,20 +33,13 @@ jobs: with: name: all-artifacts path: artifacts/ - + - name: Upload Best Model Artifact uses: actions/upload-artifact@v4.4.0 with: name: model path: artifacts/model.pkl - - name: tree - uses: jaywcjlove/github-action-folder-tree@main - id: tree - with: - path: ./ - depth: 3 - test_model: needs: train_and_upload name: Unit Test Model Artifacts @@ -80,4 +73,4 @@ jobs: echo "All required files are present." - name: Run Model Inference Test Action - uses: PLtier/itu-sdse-project-model-validator@main + uses: lasselundstenjensen/itu-sdse-project-model-validator@main diff --git a/Makefile b/Makefile index dd6e3ca..24b240c 100644 --- a/Makefile +++ b/Makefile @@ -6,7 +6,11 @@ all: setup test .PHONY: setup setup: venv $(VENV)/pre-commit install + go mod download .PHONY: test test: - dagger run go test -v \ No newline at end of file + dagger run go test -v + +.PHONY: container_run + dagger run go run pipeline.go \ No newline at end of file diff --git a/github_dagger_workflow_project/03_model_selection.py b/github_dagger_workflow_project/03_model_selection.py index 0e1f44d..0f7a759 100644 --- a/github_dagger_workflow_project/03_model_selection.py +++ b/github_dagger_workflow_project/03_model_selection.py @@ -33,7 +33,8 @@ def save_best_model(experiment_best, best_model_type) -> None: experiment_best = select_best_model(experiment_name) # Save best model -# Currently we pick only LR, no matter what the best model is. When ready, uncomment to consider xgboost. +# Currently we pick only LR, no matter what the best model is. +# When ready, uncomment to consider xgboost. # best_model_type = experiment_best["params.model_type"] # and comment below code best_model_type = "LogisticRegression" diff --git a/pyproject.toml b/pyproject.toml index dec64dd..feebd4e 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -37,5 +37,10 @@ ignore = [ "ISC001", # single-line-implicit-string-concatenation ] +select = [ +"E", # PEP 8 Errors +"W", # PEP 8 warnings +] +