fix(ui): 修复 MyListItem 选中时动画条的高度问题#2874
Merged
Merged
Conversation
审阅者指南此 PR 通过用基于缩放变换的动画替换基于高度的动画,并在所有选中/未选中状态下为左侧“神秘”选择条设置固定且居中的高度,修复了 MyListItem 中左侧选择条视觉高度不一致的问题。 文件级变更
提示与命令与 Sourcery 交互
自定义你的体验访问你的 控制面板 以:
获取帮助Original review guide in EnglishReviewer's GuideThis PR fixes the visual height inconsistency of the left "mystery" selection bar in MyListItem by replacing height-based animations with scale-transform based animations and enforcing a fixed, centered height for the bar in all checked/unchecked states. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - 我在这里给出了一些总体反馈:
- 新的动画逻辑会无条件地将
RectCheck.RenderTransform覆盖为一个ScaleTransform(之后再将其重置为null),这可能会与其他期望使用不同变换的调用方产生冲突;建议考虑在现有变换的基础上进行组合,或者在替换前先保存之前的变换并在结束后恢复,而不是直接替换。 customHeight、持续时间数值(例如300、120、70)以及缓动函数的选择目前在多个位置被硬编码;建议将这些提取为具名常量或共享配置,这样可以更容易地调整动画行为并保持一致性。
面向 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- The new animation logic unconditionally overwrites `RectCheck.RenderTransform` with a `ScaleTransform` (and later resets it to `null`), which may conflict with other callers that expect a different transform; consider composing with an existing transform or storing and restoring the previous transform instead of replacing it.
- The `customHeight`, duration values (e.g. `300`, `120`, `70`), and easing choices are currently hard-coded in multiple places; extracting these into named constants or a shared configuration would make the animation behavior easier to tweak and keep consistent.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- The new animation logic unconditionally overwrites
RectCheck.RenderTransformwith aScaleTransform(and later resets it tonull), which may conflict with other callers that expect a different transform; consider composing with an existing transform or storing and restoring the previous transform instead of replacing it. - The
customHeight, duration values (e.g.300,120,70), and easing choices are currently hard-coded in multiple places; extracting these into named constants or a shared configuration would make the animation behavior easier to tweak and keep consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new animation logic unconditionally overwrites `RectCheck.RenderTransform` with a `ScaleTransform` (and later resets it to `null`), which may conflict with other callers that expect a different transform; consider composing with an existing transform or storing and restoring the previous transform instead of replacing it.
- The `customHeight`, duration values (e.g. `300`, `120`, `70`), and easing choices are currently hard-coded in multiple places; extracting these into named constants or a shared configuration would make the animation behavior easier to tweak and keep consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LinQingYuu
requested changes
May 22, 2026
LinQingYuu
approved these changes
May 23, 2026
LuLu-ling
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
让他的高度能够固定。在旧版,默认的高度和选中的高度不一致
Summary by Sourcery
修复并统一 MyListItem 选中指示条的视觉行为,确保其具有一致的固定高度,并提供更流畅的显示/隐藏动画。
Bug 修复:
增强优化:
Original summary in English
Summary by Sourcery
Fix and standardize the visual behavior of the MyListItem selection indicator bar, ensuring a consistent fixed height and smoother show/hide animation.
Bug Fixes:
Enhancements: