Close button

[PhilETaylor]

Im not convinced the close button (and the closing of the dialog by pressing esc or clicking outside) is working as expected.

I was expecting that on closing the dialog the new code at

cmd-dialog/src/cmd-dialog.ts

Line 286 in 57617f1

this._results = this.actions;

would be resetting all the actions to be shown again, that is not happening,

To replicate type github, click X, open the cmd+k, and see that only Github is showing, no other actions are visible, I think your intention here was that all should be visible because of this._results = this.actions; which doesnt seem to be working

Screen.Recording.2024-01-03.at.13.04.55.mov

[OzzyCzech]

Thanks you for reporting this bug. I do not know why it happened, there should be an onclose action that resets the dialogue to default values, but it does not seem to work well. I will try to find out how to fix it.

The Close button has not been released yet and will allow you to easily close the dialogue on mobile devices. I will definitely add some options to hide this button.

[OzzyCzech]

The button to close the dialog is hidden by default, it can be shown using the parameter showCloseButton="true".

<cmd-dialog showCloseButton="true"></cmd-dialog>

[PhilETaylor]

This issue is not about the showing/hiding of the close button - its about the cmd+k not resetting on each invoke and still containing the previously filtered results.

• cmd+k
• type github - note that demo data filtered to just one item
• click X to close
• cmd+k
• note that the search term is empty - but the demo data is STILL filtered to just one item (the Github link)

thats the bug. On the second comd+k invoke, the search results should be reset to the full list OR the previously searched term that produced the filtered result shown, should be reshown too.

[OzzyCzech]

I know that was just a reaction to the first sentence about the close button. This problem, as you describe it, is unfortunately still present.

[PhilETaylor]

No worries - I might find some time this weekend to circle back to this project and see if I can fix this myself.

Since finding your project, I've learned so much about Web Components and LitElement thanks to you, and a million LitUniversity videos (started here https://www.youtube.com/playlist?list=PLbhRdTr_I1Ti6cdipmHHGeNag2cT7znEF) and now I have several LitElements in my interfaces! Even have one in a client project haha.

[OzzyCzech]

Both issues are now resolved:

• Close button — can be shown with showCloseButton="true" (available since v2.1.0)
• Filtered results not resetting — fixed in 6ab1fda, the search state is now properly reset when the dialog closes

[PhilETaylor]

Thanks - not going to lie, I still use this project in mySites.guru but for new client work I moved to a Claude.ai implementation similar to the Github one with sub sections available via tabbing... its insanely good. I might come back to this project as I move to improve mySites.guru later in the year, and might have some new ideas then.

Also wanted to say a personal thanks to you (via this project) as it introduced me to Lit Elements for the first time, although I knew "of" Web Components I had never actually used them myself... I just knew about them and knew Youtube used them - but through reverse engineering this specific project I became quite good with Lit and now have many live Lit Elements in multiple projects, and could not have dreamed of that before learning through your project - so thank you for the education!

[OzzyCzech]

Thank you Phil, really appreciate the kind words! I'm glad this project helped you discover Lit and Web Components — that's honestly the best feedback a maintainer can get.

I have to admit I didn't have much time to dedicate to this project either. But times have changed — AI has transformed everything. Things that used to take days are now done in minutes. On the other hand, I can proudly say this project was originally built the old-fashioned way, by human hands, before the AI era 😄

[PhilETaylor]

the old-fashioned way, by human hands, before the AI era

A badge of honour right there haha... Claude Code (in the terminal) pretty much runs every area of my life now and writes 90% of my daily code output... it has helped me become a better developer for sure... especially when doing interfaces or web app design work... Im not a javascript developer, never learned JS past the jQuery decade, never really got into ES or the fancy JS Frameworks... claude is an expert in all those and makes "widgets" in seconds for me now haha... its a totally different world since we last spoke!