[Bug]: block in resolve_settings

[JRDavisUF]

Is this a critical security issue?

• This is not a security issue.

Describe the Bug

OpenVox server displays this message when trying to list certs (tried rebooting computer and restarting server itself, same error appears):

/opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/config/puppet.rb:146:in block in resolve_settings': undefined method sub' for nil:NilClass (NoMethodError)

        subbed_value = setting_value.sub(unresolved_setting, substitutions)
                                    ^^^^
    from /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/config/puppet.rb:143:in `each'
    from /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/config/puppet.rb:143:in `resolve_settings'
    from /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/config/puppet.rb:76:in `load'
    from /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/config/puppet.rb:28:in `parse'
    from /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/action/list.rb:82:in `run'
    from /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems/openvoxserver-ca-3.0.0/lib/puppetserver/ca/cli.rb:102:in `run'
    from /opt/puppetlabs/server/apps/puppetserver/cli/apps/ca:5:in `<main>'

Expected Behavior

Nothing should be displayed as all of the certs have been signed.

Steps to Reproduce

puppetserver ca list

Environment

(from the repo)
openvox-agent-8.23.1-1.el8.x86_64
openvox-server-8.11.0-1.el8.noarch
openvox8-release-1-1.el8.noarch
openvoxdb-8.11.0-1.el8.noarch
openvoxdb-termini-8.11.0-1.el8.noarch

Redhat 8

Additional Context

There seems to be no issue with agents connecting.

Also tried to downgrade using: yum downgrade openvox-server-8.8.1-1.el8.noarch

This results in a different error (not sure if this is relevant, but figured I'd mention:

/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1466:in rescue in block in activate_dependencies': Could not find 'facter' (>= 2.0.1, < 5) among 110 total gem(s) (Gem::MissingSpecError) Checked in 'GEM_PATH=/root/.gem/ruby/3.2.0:/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0:/opt/puppetlabs/puppet/lib/ruby/vendor_gems' at: /opt/puppetlabs/puppet/lib/ruby/vendor_gems/specifications/puppetserver-ca-2.6.0.gemspec, execute gem envfor more information from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1463:inblock in activate_dependencies'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in each' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in activate_dependencies'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1434:in activate' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems.rb:210:in rescue in try_activate'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems.rb:203:in try_activate' from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:155:in rescue in require'
from internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb:40:in require' from /opt/puppetlabs/server/apps/puppetserver/cli/apps/ca:3:in

'
/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/dependency.rb:315:in to_specs': Could not find 'facter' (>= 2.0.1, < 5) among 110 total gem(s) (Gem::MissingSpecError) Checked in 'GEM_PATH=/root/.gem/ruby/3.2.0:/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0:/opt/puppetlabs/puppet/lib/ruby/vendor_gems' , execute gem envfor more information from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1464:inblock in activate_dependencies'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in each' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in activate_dependencies'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1434:in activate' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems.rb:210:in rescue in try_activate'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems.rb:203:in try_activate' from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:155:in rescue in require'
from internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb:40:in require' from /opt/puppetlabs/server/apps/puppetserver/cli/apps/ca:3:in '
/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1466:in rescue in block in activate_dependencies': Could not find 'facter' (>= 2.0.1, < 5) among 110 total gem(s) (Gem::MissingSpecError) Checked in 'GEM_PATH=/root/.gem/ruby/3.2.0:/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0:/opt/puppetlabs/puppet/lib/ruby/vendor_gems' at: /opt/puppetlabs/puppet/lib/ruby/vendor_gems/specifications/puppetserver-ca-2.6.0.gemspec, execute gem envfor more information from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1463:inblock in activate_dependencies'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in each' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in activate_dependencies'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1434:in activate' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems.rb:204:in try_activate'
from internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb:155:in rescue in require' from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:40:in require'
from /opt/puppetlabs/server/apps/puppetserver/cli/apps/ca:3:in <main>' /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/dependency.rb:315:in to_specs': Could not find 'facter' (>= 2.0.1, < 5) among 110 total gem(s) (Gem::MissingSpecError)
Checked in 'GEM_PATH=/root/.gem/ruby/3.2.0:/opt/puppetlabs/puppet/lib/ruby/gems/3.2.0:/opt/puppetlabs/puppet/lib/ruby/vendor_gems' , execute gem env for more information
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1464:in block in activate_dependencies' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in each'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1452:in activate_dependencies' from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/specification.rb:1434:in activate'
from /opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems.rb:204:in try_activate' from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:155:in rescue in require'
from internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb:40:in require' from /opt/puppetlabs/server/apps/puppetserver/cli/apps/ca:3:in '
internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb:86:in require': cannot load such file -- puppetserver/ca/cli (LoadError) from <internal:/opt/puppetlabs/puppet/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:86:in require'
from /opt/puppetlabs/server/apps/puppetserver/cli/apps/ca:3:in `'

Relevant log output

[JRDavisUF]

Should also note that the same error appears with the following commands as well:

puppetserver ca list --all
puppetserver ca clean --certname (hostname)

Also, ca stuff is located in: /etc/puppetlabs/puppetserver/ca

[JRDavisUF]

I figured out what caused the problem and how to remediate it...but it might be a good idea for check for such problems.

In the [main] section of my puppet.conf file, I had the following:
[main]
server =

Later on, I have server_list defined (not server), so everything works ok, but the lack of a supplied value breaks the settings parser.

[JRDavisUF]

..and the reason this happened was that OpenVox both sets setting server_list and un-setting server which just blanked out the server value, not actually removing it. Luckily, this change to the parser only affected the CA otherwise all my agents would have died too :)