Skip to content

Input parameters of passwords and private keys are visible in the UI #21

@nyuuyn

Description

@nyuuyn

Current Behavior:
In some older version parameters which represented passwords (e.g. DBMSPassword) the input field hid the value (e.g. pw is shown as: ********).

Additionally, in older version if a parameter was a PrivateKey (e.g. VMPrivateKey) the input field didn't mess up the PrivateKey from a string perspective (e.g. the private key is broken and can't be used by some artefacts such as the SSH service for virtual machines)

Expected Behavior:
Password parameter values are hidden, PrivateKeys are still valid after pasting them into the field.

Steps to Reproduce:

  1. Use any CSAR (e.g. MyTinyTodo with MySQL) which has atleast one Password Parameter
  2. Use any CSAR which has a PrivateKey Input Parameter

Other Information:
Params not beeing hidden or well formatted:

screen shot 2018-03-19 at 14 51 39

Some logs when the private key is really needed:

screen shot 2018-03-19 at 14 51 18 2

P.S.: I know we can just escape the returns, but well, does it have to be done?! :P

System Information:
Mac OS X with Docker Setup and Chrome

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions