Please document how PWM LEDs and buttons should be connected

[Lycowolf]

Hi,

I just finished a custom build of a fight stick and found out that my player LEDs are inverted. It seems like you expect the LEDs to use common anode (i. e. connect one lead to +3.3V, the other one to the GPIO pin), while I used a common cathode - the same as with the buttons.

I think I read all the relevant documentation and found no mention about how to connect buttons and LEDs. Search also found nothing.

I suggest putting two schematics at https://gp2040-ce.info/controller-build/wiring that would show the circuit for few buttons and few PWM LEDs, and to link to it from https://gp2040-ce.info/web-configurator/menu-pages/gpio-pin-mapping and https://gp2040-ce.info/web-configurator/menu-pages/led-configuration - that should prevent future misunderstandings IMHO.

BTW, I tried to fix it in software, but was unable to compile latest stable version (0.7.11) - I just couldn't find a compatible version of pico_sdk, either I got errors about redefined functions or missing uint8_t types :-(

[TheTrainGoes]

Hi @Lycowolf ,

Thank you for the feedback.

Common anode was chosen for this as it matched some of the available (at the time) player LED strips.

Please feel free to submit a PR with your recommended changes and we can take a look.

[Lycowolf]

OpenStickCommunity/Site#111

I didn't realize the docs are in a separate repo. If necessary, I can close this issue and open it for the "site" repo.

[TheTrainGoes]

@Lycowolf I checked the PR, looks good overall. I left a few pieces of feedback on it.

[Lycowolf]

@Lycowolf I checked the PR, looks good overall. I left a few pieces of feedback on it.

Hi, sorry for the delay, I was sick.

Where can I find your feedback? The PR has no comments and I can't see any inline notes in the "files changed" tab.

[TheTrainGoes]

@Lycowolf looks like I didn't press the right button so it was just sitting in limbo. You should see it all now.