fix: ommit geocoding location if full address is provided

Author: smarcet

app/Services/Model/Imp/SummitLocationService.php

@@ -164,7 +164,8 @@ public function addLocation(Summit $summit, array $data)
             if ($location instanceof SummitGeoLocatedLocation) {
                 try {
                     $geo_location_strategy = GeoLocationStrategyFactory::build($location);
-                    $geo_location_strategy->doGeoLocation($location, $this->geo_coding_api);
+                    if(!is_null($geo_location_strategy))
+                        $geo_location_strategy->doGeoLocation($location, $this->geo_coding_api);
                 } catch (GeoCodingApiException $ex1) {
                     Log::warning($ex1->getMessage());
                     $validation_msg = trans('validation_errors.LocationService.addLocation.geoCodingGenericError');
@@ -2639,4 +2640,4 @@ public function updateBookableRoomReservation($summit, int $room_id, int $reserv
 
         return $reservation;
     }
-}
+}

app/Services/Model/Strategies/GeoLocation/GeoLocationStrategyFactory.php

@@ -20,11 +20,19 @@ final class GeoLocationStrategyFactory
 {
     /**
      * @param SummitGeoLocatedLocation $location
-     * @return IGeoLocationStrategy
+     * @return IGeoLocationStrategy|null
      */
-    public static function build(SummitGeoLocatedLocation $location){
-        if (!empty($location->getAddress1()))
+    public static function build(SummitGeoLocatedLocation $location):?IGeoLocationStrategy{
+        $has_address = !empty($location->getAddress1()) &&
+                !empty($location->getZipCode())&&
+                !empty($location->getState()) &&
+                !empty($location->getCity()) &&
+                !empty($location->getCountry());
+        $has_lat_lng = !empty($location->getLat()) && !empty($location->getLng());
+        if ($has_address && !$has_lat_lng)
             return new GeoLocationAddressInfoStrategy();
-        return new GeoLocationReverseStrategy();
+        if($has_lat_lng && !$has_address)
+            return new GeoLocationReverseStrategy();
+        return null;
     }
-}
+}