Remove params from videoId, adjust thumbnail position (#523)

tomrndom · web-flow · commit 4896d3451700 · 2023-11-02T14:23:26.000-03:00
* Remove params from videoId, adjust thumbnail position

Signed-off-by: Tomás Castillo &lt;tcastilloboireau@gmail.com&gt;

* Add TODO to check regex for videoId

Signed-off-by: Tomás Castillo &lt;tcastilloboireau@gmail.com&gt;

---------

Signed-off-by: Tomás Castillo &lt;tcastilloboireau@gmail.com&gt;
diff --git a/src/components/LazyLoadVideo/index.js b/src/components/LazyLoadVideo/index.js
@@ -15,7 +15,8 @@ function LazyLoadVideo({ videoUrl }) {
     }, []);
 
     const getVideoId = (url) => {
-        return url.replace('https://www.youtube.com/embed/', '');
+        // TODO: get a better match method ( regex )
+        return url.replace('https://www.youtube.com/embed/', '').split('?')[0];
     }
 
     const loadVideo = () => {
diff --git a/src/components/LazyLoadVideo/index.module.scss b/src/components/LazyLoadVideo/index.module.scss
@@ -10,7 +10,7 @@
     position: absolute;
     width: 100%;
     height: auto;
-    top: 0;
+    top: -30px;
     left: 0;
     opacity: 0.7;
 }

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,8 @@ function LazyLoadVideo({ videoUrl }) {`
`15`	`15`	`}, []);`
`16`	`16`
`17`	`17`	`const getVideoId = (url) => {`
`18`		`- return url.replace('https://www.youtube.com/embed/', '');`
	`18`	`+ // TODO: get a better match method ( regex )`
	`19`	`+ return url.replace('https://www.youtube.com/embed/', '').split('?')[0];`
`19`	`20`	`}`
`20`	`21`
`21`	`22`	`const loadVideo = () => {`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`position: absolute;`
`11`	`11`	`width: 100%;`
`12`	`12`	`height: auto;`
`13`		`- top: 0;`
	`13`	`+ top: -30px;`
`14`	`14`	`left: 0;`
`15`	`15`	`opacity: 0.7;`
`16`	`16`	`}`