[ADD] active field to spp.audit.rule for soft-delete support

Implements the TODO to add an active field to audit rules, allowing
users to archive rules instead of deleting them. Inactive rules are
excluded from hook registration and normal searches.

Author: claude

spp_audit_log/models/spp_audit_rule.py

@@ -11,8 +11,7 @@ class SppAuditRule(models.Model):
     _description = "SPP Audit Rule"
 
     name = fields.Char(required=True)
-    # TODO: should we need to add active field?
-    # active = fields.Boolean(default=True)
+    active = fields.Boolean(default=True)
     log_create = fields.Boolean("Log Creation", default=True)
     log_write = fields.Boolean("Log Update", default=True)
     log_unlink = fields.Boolean("Log Deletion", default=True)
@@ -131,9 +130,9 @@ def _register_hook(self, ids=None):
         self = self.sudo()
         updated = False
         if ids:
-            rules = self.browse(ids)
+            rules = self.browse(ids).filtered(lambda r: r.active)
         else:
-            rules = self.search([])
+            rules = self.search([])  # search() excludes inactive records by default
         for rule in rules:
             if rule.model_id.model not in self.env.registry.models:
                 continue

spp_audit_log/tests/test_spp_audit_rule.py

@@ -88,3 +88,29 @@ def test_get_audit_log_vals(self):
         self.assertEqual(res_id, vals["res_id"])
         self.assertEqual(method, vals["method"])
         self.assertEqual(repr(data[res_id]), vals["data"])
+
+    def test_active_field_default(self):
+        """Test that new audit rules are active by default."""
+        model_2 = self.env["ir.model"].search([("model", "=", "res.users")], limit=1)
+        new_rule = self.create_audit_rule(name="Active Rule Test", model_id=model_2.id)
+        self.assertTrue(new_rule.active, "New audit rules should be active by default")
+
+    def test_inactive_rule_excluded_from_search(self):
+        """Test that inactive rules are excluded from normal searches."""
+        model_2 = self.env["ir.model"].search([("model", "=", "res.currency")], limit=1)
+        rule = self.create_audit_rule(name="Inactive Rule Test", model_id=model_2.id)
+
+        # Rule should be found when active
+        found = self.env["spp.audit.rule"].search([("id", "=", rule.id)])
+        self.assertEqual(len(found), 1)
+
+        # Deactivate the rule
+        rule.active = False
+
+        # Rule should not be found in normal search
+        found = self.env["spp.audit.rule"].search([("id", "=", rule.id)])
+        self.assertEqual(len(found), 0)
+
+        # Rule should be found with active_test=False context
+        found = self.env["spp.audit.rule"].with_context(active_test=False).search([("id", "=", rule.id)])
+        self.assertEqual(len(found), 1)

spp_audit_log/views/spp_audit_rule_views.xml

@@ -13,6 +13,7 @@
         <field name="log_unlink" />
         <field name="view_logs" />
         <field name="model_id" />
+        <field name="active" optional="hide" />
       </tree>
     </field>
   </record>