Skip to content

Commit 1561073

Browse files
committed
[REF] refactor code
1 parent 5bcd52e commit 1561073

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

spp_api/controllers/api.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ def read_multi__GET(self, namespace, version, model, **kw):
218218
except (ValueError, TypeError):
219219
page = 1
220220
page = max(1, page)
221+
kw["page"] = page
221222

222223
kw = path.search_treatment_kwargs(kw)
223224
limit = kw.get("limit")
@@ -243,7 +244,7 @@ def read_multi__GET(self, namespace, version, model, **kw):
243244
"page": page,
244245
"limit": limit,
245246
"total_records": records_all,
246-
"total_pages": (records_all + limit - 1) // limit if limit > 0 else 1,
247+
"total_pages": max(1, (records_all + limit - 1) // limit if limit > 0 else 1),
247248
}
248249

249250
return successful_response(200, response_data)

spp_api/models/spp_api_path.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -676,11 +676,7 @@ def search_treatment_kwargs(self, kwargs):
676676
del kwargs["start_from"]
677677
else:
678678
# Page
679-
try:
680-
page = int(kwargs.get("page", 1))
681-
except (ValueError, TypeError):
682-
page = 1
683-
page = max(1, page)
679+
page = int(kwargs.get("page", 1))
684680

685681
# Get defined limit first in spp_api.path
686682
# if limit is defined in kwargs (query parameter), use it; else use self.limit or MAX_LIMIT

0 commit comments

Comments
 (0)