Type of command is not correct

[AjeyBharadwaj]

The type of leaf "command" is : "base sw-manifest-commands;"
But, for "delete-file" option in "delete-file-command" to be accesible, it should be of type "base manifest-commands;"

I think the leaf "command" should be a union of "base sw-manifest-commands;" and "base manifest-commands;"

Type of command :

OpenROADM_MSA_Public/model/Common/org-openroadm-manifest-file.yang

Line 838 in aaa5a0e

base sw-manifest-commands;

Type of delete-file :

OpenROADM_MSA_Public/model/Common/org-openroadm-manifest-file.yang

Line 97 in aaa5a0e

base manifest-commands;

Condtion :

OpenROADM_MSA_Public/model/Common/org-openroadm-manifest-file.yang

Line 401 in aaa5a0e

when "../command = 'delete-file'";

[fgruman]

@AjeyBharadwaj
I just got a chance to look at this item.

i think the issue that you are describing is as follows:
In SWDL, the command type is sw-manifest-commands.
However, to do a SWDL operation, we may need to issue the file transfer command.
But the file transfer (and delete) commands are under the identity type of manifest-commands, not sw-manifest-commands.
So we would not be able to specify download-file, upload-file, or delete-file in the SWDL process as they do not conform to the base sw-manifest-commands.

This issue would also be in the database backup and restore sections.

Is this a correct understanding?

[AjeyBharadwaj]

Yes.
We might have to change the base identity of all options to one (not a good design) OR, make type of command as union which accepts from both identity refs.

[fgruman]

@orenais @beegeesquare
I think we have addressed this issue and can close this item.
I think this was addressed in MSA 9.0

[orenais]

No objection to close it if you feel the issue was addressed. Thanks