Skip to content

Commit 4db2be9

Browse files
committed
feat: Implement FEATURE_BUNDLE_1 RFC 0004
I used the following prompt for LLM evaluation of this code change against RFC 0004 in openjd-specifications: > You are a helpful RFC conformance reviewer. Another agent has > implemented RFC 0004, along with tests, in the most recent commit. Your > job is to carefully inspect the RFC, the RFC-specific details in the > OpenJD spec, and look at all the code changes to evaluate compliance. > Produce a report on the quality of the implementation. How well does it > conform? Give each relevant section/subsection of the spec a score. Also > look at the unit tests and evaluate that it is covering all edge cases > of the spec. Write your report to the file CONFORMANCE_REPORT.md. All code also reviewed by hand. Signed-off-by: Mark <399551+mwiebe@users.noreply.github.com>
1 parent d14a9ce commit 4db2be9

File tree

6 files changed

+1631
-38
lines changed

6 files changed

+1631
-38
lines changed

src/openjd/model/_internal/_validator_functions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def validate_int_fmtstring_field(
1414
ge: Optional[int] = None,
1515
*,
1616
context: Optional[ModelParsingContextInterface],
17-
) -> Union[int, float, Decimal, FormatString]:
17+
) -> Union[int, FormatString]:
1818
"""Validates a field that is allowed to be either an integer, a string containing an integer,
1919
or a string containing expressions that resolve to an integer."""
2020
value_type_wrong_msg = "Value must be an integer or a string containing an integer."
@@ -57,7 +57,7 @@ def validate_float_fmtstring_field(
5757
ge: Optional[Decimal] = None,
5858
*,
5959
context: Optional[ModelParsingContextInterface],
60-
) -> Union[int, float, Decimal, FormatString]:
60+
) -> Union[Decimal, FormatString]:
6161
"""Validates a field that is allowed to be either an float, a string containing an float,
6262
or a string containing expressions that resolve to a float."""
6363
value_type_wrong_msg = "Value must be a float or a string containing a float."

src/openjd/model/v2023_09/__init__.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
EmbeddedFiles,
3030
EmbeddedFileText,
3131
EmbeddedFileTypes,
32+
EndOfLine,
3233
Environment,
3334
EnvironmentActions,
3435
EnvironmentName,
@@ -64,6 +65,8 @@
6465
PathTaskParameterDefinition,
6566
RangeExpressionTaskParameterDefinition,
6667
RangeListTaskParameterDefinition,
68+
ScriptInterpreter,
69+
SimpleAction,
6770
Step,
6871
StepActions,
6972
StepEnvironmentList,
@@ -113,6 +116,7 @@
113116
"EmbeddedFiles",
114117
"EmbeddedFileText",
115118
"EmbeddedFileTypes",
119+
"EndOfLine",
116120
"Environment",
117121
"EnvironmentActions",
118122
"EnvironmentScript",
@@ -148,6 +152,8 @@
148152
"PathTaskParameterDefinition",
149153
"RangeExpressionTaskParameterDefinition",
150154
"RangeListTaskParameterDefinition",
155+
"ScriptInterpreter",
156+
"SimpleAction",
151157
"Step",
152158
"StepActions",
153159
"StepEnvironmentList",

0 commit comments

Comments
 (0)