Assistant: Rethink `session_type`

[josephjclark]

When creating a chat session in the assistant, we assign that session a type - either workflow_template or job_code

Back when we had split assistants, this made sense. But now the session is more fluid. You can start a session in workflow chat, then move into job code, then go back and edit your workflow.

This is affecting our reporting and monitoring. When we filter messages by which chat service is being used, the session is usually (or maybe always?) workflow_template, because that's where we start. So it's hard now to filter for all job_chat sessions.

This problem will get worse as we move to the global assistant. In a few months time (hopefully) Lightning won't know which agent its using, so we can't make this filter at all.

So I'm not sure of the answer here. Certainly I think we need to drop the type from the session, it's very confusing. Should we add an endpoint or agent key to each message? Maybe we should add the page URL - or a simplified one - to each message?

[josephjclark]

@hanna-paasivirta this isn't as straightforward as it looks, because the session shouldn't be typed any more. And as we move into the global assistant more and more, questions like "how many job chat questions were asked?" make less and less sense.

[theroinaochieng]

@stuartc another one for your awareness