-
Notifications
You must be signed in to change notification settings - Fork 61
Open
Labels
bugNewly identified bugNewly identified bug
Description
Describe the bug The success toast message for Save & Sync does not have the link to GitHub actions as the legacy editor:
Version number v2.15.6
I have reproduced this locally on main:
- Yes
- No
To Reproduce Steps to reproduce the behavior:
- Save & Sync on a workflow on collaborative editor
Expected behaviour Toast message should have a link in it to GitHub actions
Screenshots
Additional context
This PR should also allow notifications.description to accept JSX as well as a string, so that we can add links in other toast messages.
previous editor success message:
def github_sync_successfull_flash(assigns) do
~H"""
<span>
Workflow saved and sync requested. Check the
<.link href={@link_to_actions} target="_blank" class="link">
Github actions
</.link>
for result
</span>
"""
end
collaborative editor:
// Show success toast
const successOptions: { title: string; description?: string } = {
title: 'Workflow saved and synced to GitHub',
};
if (response.repo) {
successOptions.description = `Changes pushed to ${response.repo}`;
}
notifications.success(successOptions);
Metadata
Metadata
Assignees
Labels
bugNewly identified bugNewly identified bug
Type
Projects
Status
New Issues
