Skip to content

Restore link to GitHub actions in GitHub save & sync success toast message #4281

@lmac-1

Description

@lmac-1

Describe the bug The success toast message for Save & Sync does not have the link to GitHub actions as the legacy editor:

Version number v2.15.6

I have reproduced this locally on main:

  • Yes
  • No

To Reproduce Steps to reproduce the behavior:

  1. Save & Sync on a workflow on collaborative editor

Expected behaviour Toast message should have a link in it to GitHub actions

Screenshots

Collaborative editor:
Image

Additional context
This PR should also allow notifications.description to accept JSX as well as a string, so that we can add links in other toast messages.

previous editor success message:

def github_sync_successfull_flash(assigns) do
    ~H"""
    <span>
      Workflow saved and sync requested. Check the
      <.link href={@link_to_actions} target="_blank" class="link">
        Github actions
      </.link>
      for result
    </span>
    """
  end

collaborative editor:

// Show success toast
        const successOptions: { title: string; description?: string } = {
          title: 'Workflow saved and synced to GitHub',
        };
        if (response.repo) {
          successOptions.description = `Changes pushed to ${response.repo}`;
        }
        notifications.success(successOptions);

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugNewly identified bug

    Type

    No type

    Projects

    Status

    New Issues

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions