From 6595af6a71026765802be7cf897292c3271b1b9a Mon Sep 17 00:00:00 2001 From: Janne Peltonen Date: Fri, 19 Dec 2025 11:42:52 +0200 Subject: [PATCH 1/3] api: crypto: specify default value for output_pool session parameter Now that the deprecated legacy crypto operation mode has been fully removed from the API, the output_pool crypto session parameter is no longer used. Change the description of the parameter to mention that the parameter is not used and will be deprecated. Specify that the parameter must be left to the default value and that the default value is ODP_POOL_INVALID. This way existing code that is setting the output_pool session parameter to ODP_POOL_INVALID continues to be valid but it becomes possible to remove the explicit setting of the parameter as preparation for its eventual deprecation. Signed-off-by: Janne Peltonen Reviewed-by: Tuomas Taipale Reviewed-by: Petri Savolainen --- include/odp/api/spec/crypto_types.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/include/odp/api/spec/crypto_types.h b/include/odp/api/spec/crypto_types.h index 27aeb40537..365857e214 100644 --- a/include/odp/api/spec/crypto_types.h +++ b/include/odp/api/spec/crypto_types.h @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright (c) 2014-2018 Linaro Limited - * Copyright (c) 2021-2024 Nokia + * Copyright (c) 2021-2025 Nokia */ /** @@ -920,8 +920,10 @@ typedef struct odp_crypto_session_param_t { /** Output pool * - * In ODP_CRYPTO_OP_TYPE_BASIC and ODP_CRYPTO_OP_TYPE_OOP - * operation types this must be set to ODP_POOL_INVALID. + * This field is unused and will be deprecated later. + * The value must be left to the default value. + * + * Default value is ODP_POOL_INVALID. */ odp_pool_t output_pool; From 18b777397daea4c7a69fafb60902911ca7a48d4f Mon Sep 17 00:00:00 2001 From: Janne Peltonen Date: Fri, 19 Dec 2025 11:57:39 +0200 Subject: [PATCH 2/3] validation: crypto: test default value of output_pool parameter Test that the default value of the output_pool crypto session parameter is ODP_POOL_INVALID as now specified in the API and rely on the default value when creating sessions. Signed-off-by: Janne Peltonen Reviewed-by: Tuomas Taipale Reviewed-by: Petri Savolainen --- test/validation/api/crypto/odp_crypto_test_inp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index 72b2e9c738..13c3249eb0 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -44,6 +44,7 @@ static void test_defaults(uint8_t fill) CU_ASSERT(param.auth_alg == ODP_AUTH_ALG_NULL); CU_ASSERT(param.auth_iv_len == 0); CU_ASSERT(param.auth_aad_len == 0); + CU_ASSERT(param.output_pool == ODP_POOL_INVALID); } static void test_default_values(void) @@ -212,7 +213,6 @@ static int session_create(crypto_session_t *session, ses_params.cipher_alg = ref->cipher; ses_params.auth_alg = ref->auth; ses_params.compl_queue = suite_context.queue; - ses_params.output_pool = ODP_POOL_INVALID; ses_params.cipher_key = cipher_key; ses_params.cipher_iv_len = ref->cipher_iv_length; ses_params.auth_iv_len = ref->auth_iv_length; From 28d5a55de00c9c8d69162007399979f7a21f3b51 Mon Sep 17 00:00:00 2001 From: Janne Peltonen Date: Fri, 19 Dec 2025 12:05:15 +0200 Subject: [PATCH 3/3] test: pipeline: do not set output_pool crypto session parameter Do not explicitly set the output_pool crypto session parameter but rely on the default value set by odp_crypto_session_param_init(). Signed-off-by: Janne Peltonen Reviewed-by: Tuomas Taipale Reviewed-by: Petri Savolainen --- test/performance/pipeline/crypto_parser.c | 1 - 1 file changed, 1 deletion(-) diff --git a/test/performance/pipeline/crypto_parser.c b/test/performance/pipeline/crypto_parser.c index e5b48f22e9..a1aa051877 100644 --- a/test/performance/pipeline/crypto_parser.c +++ b/test/performance/pipeline/crypto_parser.c @@ -115,7 +115,6 @@ static odp_bool_t parse_crypto_entry(config_setting_t *cs, crypto_parse_t *crypt crypto->param.op_mode = ODP_CRYPTO_ASYNC; crypto->param.cipher_key.data = NULL; crypto->param.auth_key.data = NULL; - crypto->param.output_pool = ODP_POOL_INVALID; if (config_setting_lookup_string(cs, CONF_STR_NAME, &val_str) == CONFIG_FALSE) { ODPH_ERR("No \"" CONF_STR_NAME "\" found\n");