Skip to content

Commit 7fefa41

Browse files
Update tests/integration/testutils/db.go
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 9a8cf28 commit 7fefa41

2 files changed

Lines changed: 17 additions & 16 deletions

File tree

.github/workflows/integration-tests.yml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,11 @@ jobs:
118118
PORT=8082 \
119119
LOG_LEVEL=debug \
120120
DB_SSLMODE=disable \
121-
CHOREO_OPENDIF_DATABASE_HOSTNAME=localhost \
122-
CHOREO_OPENDIF_DATABASE_PORT=5433 \
123-
CHOREO_OPENDIF_DATABASE_USERNAME=postgres \
124-
CHOREO_OPENDIF_DATABASE_PASSWORD=password \
125-
CHOREO_OPENDIF_DATABASE_DATABASENAME=policy_db \
121+
CHOREO_OPENDIF_DATABASE_HOSTNAME=${CHOREO_OPENDIF_DATABASE_HOSTNAME:-localhost} \
122+
CHOREO_OPENDIF_DATABASE_PORT=${CHOREO_OPENDIF_DATABASE_PORT:-5433} \
123+
CHOREO_OPENDIF_DATABASE_USERNAME=${CHOREO_OPENDIF_DATABASE_USERNAME:-postgres} \
124+
CHOREO_OPENDIF_DATABASE_PASSWORD=${CHOREO_OPENDIF_DATABASE_PASSWORD:-password} \
125+
CHOREO_OPENDIF_DATABASE_DATABASENAME=${CHOREO_OPENDIF_DATABASE_DATABASENAME:-policy_db} \
126126
RUN_MIGRATION=true \
127127
./bin/policy-decision-point > logs/pdp.log 2>&1 &
128128
PDP_PID=$!
@@ -131,16 +131,16 @@ jobs:
131131
echo "🚀 Starting Consent Engine..."
132132
PORT=8081 \
133133
LOG_LEVEL=debug \
134-
CHOREO_DB_CE_HOSTNAME=localhost \
135-
CHOREO_DB_CE_PORT=5434 \
136-
CHOREO_DB_CE_USERNAME=postgres \
137-
CHOREO_DB_CE_PASSWORD=password \
138-
CHOREO_DB_CE_DATABASENAME=consent_db \
139-
CHOREO_OPENDIF_DATABASE_HOSTNAME=localhost \
140-
CHOREO_OPENDIF_DATABASE_PORT=5434 \
141-
CHOREO_OPENDIF_DATABASE_USERNAME=postgres \
142-
CHOREO_OPENDIF_DATABASE_PASSWORD=password \
143-
CHOREO_OPENDIF_DATABASE_DATABASENAME=consent_db \
134+
CHOREO_DB_CE_HOSTNAME=${CHOREO_DB_CE_HOSTNAME:-localhost} \
135+
CHOREO_DB_CE_PORT=${CHOREO_DB_CE_PORT:-5434} \
136+
CHOREO_DB_CE_USERNAME=${CHOREO_DB_CE_USERNAME:-postgres} \
137+
CHOREO_DB_CE_PASSWORD=${CHOREO_DB_CE_PASSWORD:-password} \
138+
CHOREO_DB_CE_DATABASENAME=${CHOREO_DB_CE_DATABASENAME:-consent_db} \
139+
CHOREO_OPENDIF_DATABASE_HOSTNAME=${CHOREO_OPENDIF_DATABASE_HOSTNAME:-localhost} \
140+
CHOREO_OPENDIF_DATABASE_PORT=${CHOREO_OPENDIF_DATABASE_PORT:-5434} \
141+
CHOREO_OPENDIF_DATABASE_USERNAME=${CHOREO_OPENDIF_DATABASE_USERNAME:-postgres} \
142+
CHOREO_OPENDIF_DATABASE_PASSWORD=${CHOREO_OPENDIF_DATABASE_PASSWORD:-password} \
143+
CHOREO_OPENDIF_DATABASE_DATABASENAME=${CHOREO_OPENDIF_DATABASE_DATABASENAME:-consent_db} \
144144
DB_SSLMODE=disable \
145145
RUN_MIGRATION=true \
146146
ASGARDEO_JWKS_URL="https://www.googleapis.com/oauth2/v3/certs" \

tests/integration/testutils/db.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ func setupPostgresDB(t *testing.T, defaultPort, defaultUser, defaultDatabase str
5252
password = os.Getenv("POSTGRES_PASSWORD")
5353
}
5454
if password == "" {
55-
// For test environments, allow default password
55+
// For test environments, allow default password but log a warning.
5656
password = "password"
57+
t.Logf("Warning: TEST_DB_PASSWORD is not set. Falling back to default password. This is not recommended for shared environments.")
5758
}
5859

5960
database := getEnvOrDefault("TEST_DB_DATABASE", defaultDatabase)

0 commit comments

Comments
 (0)