fix: screen capture for KDE on Wayland#1413
Draft
letsfindaway wants to merge 4 commits into
Draft
Conversation
Collaborator
Author
|
Added two more commits:
|
letsfindaway
force-pushed
the
fix-kde-screenshot
branch
from
a5c28aa to
11d76c7
Compare
Collaborator
Author
|
Added additional commit to refactor the desktop portal classes according to our discussion. I still have this question open: |
letsfindaway
force-pushed
the
fix-kde-screenshot
branch
from
11d76c7 to
ca6041a
Compare
- the KDE implementation of the ScreenShot portal does not allow for user clipping in interactive mode - add a function to determine the desktop environment to UBPlatformUtils - expose this function as grabCanCrop() - use this function to determine whether user clipping has to be done after the screenshot using the UBCustomCapture Window - allow interactive and non-interactive screenshots in UBDesktopPortal Signed-off-by: letsfindaway <me@letsfindaway.de>
- Plasma 6 uses another DBus path to run the loaded script - adapt UBPlatformUtils::keepOnTop to work with Plasma 5 and 6 Signed-off-by: letsfindaway <me@letsfindaway.de>
- on Wayland, a widget can only positioned to a specific screen if it is full-screen - when control screen was to the right of the display screen, the position changed when mirroring was enabled - always show the glass pane as full-screen to fix this Signed-off-by: letsfindaway <me@letsfindaway.de>
- separate UBDesktopPortal into UBScreenshotDesktopPortalWrapper and UBScreenCastDesktopPortalWrapper - extract token generator to UBDesktopPortalTokenGenerator - move showGlassPane to UBApplicationController - move Desktop Portal classes to frameworks/linux subdirectory
letsfindaway
force-pushed
the
fix-kde-screenshot
branch
from
ca6041a to
b82732f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScreenShotportal does not allow for user clipping in interactive modeUBPlatformUtilsgrabCanCrop()UBCustomCaptureWindowUBDesktopPortalNote: please see my comments in
UBDesktopPortal::handleScreenshotResponse()about coordinates of a full screenshot in non-interactive mode. This PR is a Draft until this question is resolved.