Skip to content

Android: Content provider reads have no size limit (OOM risk) #7

@0xharkirat

Description

@0xharkirat

Priority: High

OacpDiscoveryHandler.readProviderText() calls readText() with no size limit. A malicious or buggy OACP provider could return arbitrarily large data, causing OOM. This also runs on the main thread (see related issue).

Recommended fix

  • Cap reads at 1 MB: readText().take(MAX_SIZE)
  • Move discovery to a background thread
  • Add explicit SecurityException handling with clearer error messages

Files

  • android/app/src/main/kotlin/com/oacp/hark/OacpDiscoveryHandler.kt (line 80)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions